From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jNu+N9cObWDTXgAAWB0awg (envelope-from ) for ; Tue, 06 Apr 2021 21:45:59 -0400 Received: by simark.ca (Postfix, from userid 112) id D6A571E939; Tue, 6 Apr 2021 21:45:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A0CC71E789 for ; Tue, 6 Apr 2021 21:45:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF36A3894C20; Wed, 7 Apr 2021 01:45:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF36A3894C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617759957; bh=9yJMzS39Z3Bn5mp1xckHx6GWp/JvLzwb5s4zVyVSrf8=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=iA3WIZCcBymQMx5PyeMF+KUCpXwe6yQMT1jxiLsouTiqP+wNbUGlf753qRTFuGvEk nsBORLULjpT6TxK4KZekPJJNI7kUQnVOQqQB6Hf9HXTM9pPQOcwIm+G+UoQ4FEBBPX Mt1nL1rHvksiY+qb94mp9CgubO+vynfIHNHcBkoU= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7451D3894C1D for ; Wed, 7 Apr 2021 01:45:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7451D3894C1D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1371jnck030065 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 6 Apr 2021 21:45:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1371jnck030065 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CB57B1E789 for ; Tue, 6 Apr 2021 21:45:49 -0400 (EDT) Subject: Re: [PATCH] sim/m32c: fix memory leaks in opc2c To: gdb-patches@sourceware.org References: <20210405145856.3925296-1-simon.marchi@polymtl.ca> Message-ID: <13aff427-e308-33cb-0aed-4b4285c52df6@polymtl.ca> Date: Tue, 6 Apr 2021 21:45:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 7 Apr 2021 01:45:49 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > i'm not keen on pushing it in this direction exactly. it would mean every > caller would have to update & keep track. > > i think you could define an IGEN variable in common/Make-common.in and change > all callers over to that. then that would be the only place you'd have to add > any sanitizer related variables to. > -mike > I can do that, but I'm not sure where in common/Make-common.in I should add the variable. There seems to be a logic to the organization in that file, but I don't get it. Also, not that ppc has its own igen, so I guess it will still use its own definition. Another option is to just factor out the env var: DISABLE_LSAN = ASAN_OPTIONS=detect_leaks=0 ... and still use it in rules: target: source $(DISABLE_LSAN) ../igen/igen --blah Worst case, if somebody forgets to use DISABLE_LSAN somewhere, someone building with ASan will notice and it's a trivial fix to add it. Anyway, feel free to push the version you prefer, it will be faster than telling me how to do it :). Side-note, I saw some `@GMAKE_TRUE@` in Make-common.in. In GDB, we decided to require GNU make and remove that complexity, in case you want to do the same. Simon