From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20765 invoked by alias); 16 Jul 2018 18:02:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20747 invoked by uid 89); 16 Jul 2018 18:02:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:15.1.1466.3, H*RU:15.1.1466.3, Hx-spam-relays-external:15.1.1466.3, H*RU:Unknown_Domain X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jul 2018 18:02:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1531764159; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MSsKgX0y3IDqP0/BkVfP49aCq7wUdRzyJc0hoTgQx1g=; b=U5KW70wKGBNop2oY+BwQ9F4KQtuMpBZmzYWGLqhv1KIa6aCwgrQI2jU3nQ11T+eQ yDyssjTLWHG32YH2JgjXCvNzOMCedjZbdopK1aphzhYVZbQET1XB6eCI+76xy9Zs XGTtabSqBR50JrHpXUX06DgYxJxtickX33Iqo9jPMGg=; Received: from ESESBMB501.ericsson.se (Unknown_Domain [153.88.183.114]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 2F.10.31169.FBDDC4B5; Mon, 16 Jul 2018 20:02:39 +0200 (CEST) Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 16 Jul 2018 20:02:39 +0200 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Mon, 16 Jul 2018 20:02:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I2MBLu2aNVr+v7+z1ROis8Zc5BwG8RWwgax72PvWeFk=; b=jY9gh8ntIRhibSH/KjyvTDYfvkeJjsx/w55/CSL/klJEHytsm09OzrKQbvm47oWrQ6cZfJeCfwprTfRMbiE1VB+Ppc340F/UtwJHLK9mrlWfXvBO1uZFwBjyn44UCHDdCEDrVaPqbzmEHUURZvjEnpgoBGFPe8eY1K6aaQkXgWc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.61.147] (192.75.88.130) by BN7PR15MB2386.namprd15.prod.outlook.com (2603:10b6:406:8c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.18; Mon, 16 Jul 2018 18:02:36 +0000 Subject: Re: [PATCH] Make target_read_alloc & al return vectors To: Simon Marchi , Andreas Schwab CC: References: <1521691401-21512-1-git-send-email-simon.marchi@ericsson.com> <5ead66c6-e0cb-c9b6-b882-79c232cc389c@simark.ca> From: Simon Marchi Message-ID: <13ade3ae-e9ca-a9da-fd28-fbd23004f69b@ericsson.com> Date: Mon, 16 Jul 2018 18:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <5ead66c6-e0cb-c9b6-b882-79c232cc389c@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00497.txt.bz2 On 2018-07-07 11:10 AM, Simon Marchi wrote: > On 2018-07-07 04:54 AM, Andreas Schwab wrote: >> ../../gdb/ia64-tdep.c: In function ‘LONGEST getunwind_table(gdb_byte**)’: >> ../../gdb/ia64-tdep.c:2664:16: error: too many arguments to function ‘gdb::optional > > > target_read_alloc(target_ops*, target_object, const char*)’ >> NULL, buf_p); >> ^ >> In file included from ../../gdb/inferior.h:41:0, >> from ../../gdb/ia64-tdep.c:21: >> ../../gdb/target.h:341:40: note: declared here >> extern gdb::optional target_read_alloc >> ^ >> ../../gdb/ia64-tdep.c:2663:5: error: cannot convert ‘gdb::optional > > >’ to ‘LONGEST {aka long int}’ in assignment >> x = target_read_alloc (current_top_target (), TARGET_OBJECT_UNWIND_TABLE, >> ^ >> >> Andreas. >> > > Hi Andreas, > > I have been unable to build libunwind for ia64 before (using the 1.2 > branch), that's why I missed it. Now I tried to build the 1.1 and it > works fine. > > I fixed up the call to target_read_alloc to the best of my knowledge, > with as little changes to the code as possible. However, I can't test > the result more than build it. Can you please review the patch below? > > Just to confirm, do you also see errors later in the build, like: > > In file included from /home/simark/src/binutils-gdb/gdb/ia64-libunwind-tdep.c:39: > /home/simark/src/binutils-gdb/gdb/ia64-libunwind-tdep.c:114:1: error: ISO C++ forbids converting a string constant to ‘char*’ [-Werror=write-strings] > static char *get_reg_name = STRINGIFY(UNW_OBJ(get_reg)); > ^~~~~~~~~~~~~~ > /home/simark/src/binutils-gdb/gdb/common/preprocessor.h:28:25: note: in definition of macro ‘STRINGIFY_1’ > #define STRINGIFY_1(x) #x > ^ > ? > > ---- > > From efd663c4d54b64f394d51faabc74f249d0bf32a7 Mon Sep 17 00:00:00 2001 > From: Simon Marchi > Date: Sat, 7 Jul 2018 10:55:14 -0400 > Subject: [PATCH] Fix compilation error in ia64-tdep.c with libunwind-ia64 > > Commit > > 9018be22e022 ("Make target_read_alloc & al return vectors") > > failed to update the code in ia64-tdep.c, for HAVE_LIBUNWIND_IA64_H. > This patch fixes that. I pushed this patch. Simon