Re: [PATCH 1/2] Fix PR breakpoints/16889: gdb segfaults when printing ASM SDT arguments

Pedro Alves
2014-05-02T18:56:30Z

On 05/02/2014 07:06 PM, Sergio Durigan Junior wrote:
> On Friday, May 02 2014, I wrote:
>
>> Here's what I am going to push by the end of the day if there are no
>> other comments.
>
> Pedro brought something else to my attention: the testcase messages were
> not unique, and I could rewrite it in order to make it more
> automatized. So here is the third version that I will push if there are
> no other comments.

Thanks! Looks great.

FYI, with {} instead of [list ...] one can avoid the backslashes.
That is, one can write:

foreach probe_name {foo bar foo_prefix bar_prefix} \
probe_val {42 42 42 42} \
probe_reg_val {"$rsp" "$rbp - 8" "$rsp" "$rbp - 8"} {

instead of:

foreach probe_name [list "foo" "bar" "foo_prefix" "bar_prefix"] \
probe_val [list "42" "42" "42" "42"] \
probe_reg_val [list "\$rsp" "\$rbp - 8" "\$rsp" "\$rbp - 8"] {
with_test_prefix $probe_name {

Just a suggestion, it doesn't matter at all.

--
Pedro Alves