From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Return argv0-symlink.exp early if gdb can't load symlink
Date: Wed, 02 Apr 2014 08:46:00 -0000 [thread overview]
Message-ID: <1396428218-31822-1-git-send-email-yao@codesourcery.com> (raw)
We run argv0-symlink.exp on mingw32 host, and see the following error
in gdb.log
(gdb) file argv0-symlink-filelink^M
"argv0-symlink-filelink": not in executable format: File format not recognized
(gdb) ERROR: Couldn't load argv0-symlink-filelink into arm-none-eabi-gdb.
the rest of the test don't have to run.
This patch expands clean_restart so that we can check the return value
of gdb_load. Return if return value of gdb_load isn't zero.
Note that originally I added a unsupported statement to mention that
symlink is not supported, but perror in gdb_file_cmd changes it to
unresolved, so I remove that unsupported statement.
gdb/testsuite:
2014-04-02 Yao Qi <yao@codesourcery.com>
* gdb.base/argv0-symlink.exp: Return early if GDB can't load
symlink successfully.
---
gdb/testsuite/gdb.base/argv0-symlink.exp | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/gdb/testsuite/gdb.base/argv0-symlink.exp b/gdb/testsuite/gdb.base/argv0-symlink.exp
index 0e0202d..5e16b00 100644
--- a/gdb/testsuite/gdb.base/argv0-symlink.exp
+++ b/gdb/testsuite/gdb.base/argv0-symlink.exp
@@ -29,7 +29,14 @@ if {[lindex $status 0] != 0} {
return 0
}
-clean_restart "$filelink"
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+
+if { [gdb_load [standard_output_file ${filelink}]] != 0 } {
+ # GDB can't load symlink successfully, skip it.
+ return 0
+}
if ![runto_main] {
untested "could not run to main"
--
1.7.7.6
next reply other threads:[~2014-04-02 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 8:46 Yao Qi [this message]
2014-04-02 8:59 ` Yao Qi
2014-04-02 10:47 ` Pedro Alves
2014-04-02 14:06 ` Yao Qi
2014-04-02 16:44 ` Pedro Alves
2014-04-02 16:47 ` Eli Zaretskii
2014-04-10 13:19 ` Yao Qi
2014-04-02 16:14 ` Eli Zaretskii
2014-04-02 16:54 ` Pedro Alves
2014-04-02 17:20 ` Eli Zaretskii
2014-04-03 12:12 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396428218-31822-1-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox