From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5762 invoked by alias); 17 Mar 2014 15:23:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5678 invoked by uid 89); 17 Mar 2014 15:23:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Mar 2014 15:23:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2HFNEAn021811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Mar 2014 11:23:15 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2HFN5A3009032 for ; Mon, 17 Mar 2014 11:23:13 -0400 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 6/8] go32-nat.c: Don't override to_open. Date: Mon, 17 Mar 2014 15:23:00 -0000 Message-Id: <1395069784-7406-7-git-send-email-palves@redhat.com> In-Reply-To: <1395069784-7406-1-git-send-email-palves@redhat.com> References: <1395069784-7406-1-git-send-email-palves@redhat.com> X-SW-Source: 2014-03/txt/msg00368.txt.bz2 Although the string says "Done.", nothing is pushing the target as is. Removing the method override let's us fall through to the the base to_open implemention in inf-child.c, which will push the target in reaction to "target native" in a follow up patch. gdb/ 2014-03-17 Pedro Alves * go32-nat.c (go32_open): Delete. (go32_target): Don't override the to_open method. --- gdb/go32-nat.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/gdb/go32-nat.c b/gdb/go32-nat.c index ef5278a..e17707a 100644 --- a/gdb/go32-nat.c +++ b/gdb/go32-nat.c @@ -339,12 +339,6 @@ static struct { }; static void -go32_open (char *name, int from_tty) -{ - printf_unfiltered ("Done. Use the \"run\" command to run the program.\n"); -} - -static void go32_attach (struct target_ops *ops, char *args, int from_tty) { error (_("\ @@ -960,7 +954,6 @@ go32_target (void) { struct target_ops *t = inf_child_target (); - t->to_open = go32_open; t->to_attach = go32_attach; t->to_resume = go32_resume; t->to_wait = go32_wait; -- 1.7.11.7