From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5948 invoked by alias); 13 Mar 2014 02:35:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5685 invoked by uid 89); 13 Mar 2014 02:35:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Mar 2014 02:35:11 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WNvU7-0001O9-EO from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Wed, 12 Mar 2014 19:35:03 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 12 Mar 2014 19:35:03 -0700 Received: from qiyao.dyndns.org.com (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Wed, 12 Mar 2014 19:35:02 -0700 From: Yao Qi To: Subject: [PATCH 0/5] Return error code in get_number Date: Thu, 13 Mar 2014 02:35:00 -0000 Message-ID: <1394677950-4054-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00308.txt.bz2 Patch #5 tries to teach GDB to accept convenience variable in MI commands, in which we use get_number to parse string and get number. However, get_number returns zero for any kinds of error, and callers can't tell from it. Patch #4 changes get_number's interface to return parsing status and parsed number. This patch also moves some printing messages out of get_number, and let the callers to print messages according to returned status. Patch #1 - #3 are cleanups and each of them are independent. This series is tested on x86_64-linux. *** BLURB HERE *** Yao Qi (5): Remove argument 'state' from get_tracepoint_by_number Change argument 'args' of get_tracepoint_by_number to char * Emit wrong value error when parsing range get_number returns status in details Accept convenience variable in commands -break-passcount and -break-commands gdb/NEWS | 5 + gdb/breakpoint.c | 62 +++++++------ gdb/breakpoint.h | 3 +- gdb/cli/cli-utils.c | 94 ++++++++++++++------ gdb/cli/cli-utils.h | 20 ++++- gdb/mi/mi-cmd-break.c | 26 ++++-- gdb/reverse.c | 6 +- gdb/testsuite/gdb.base/ena-dis-br.exp | 9 ++ gdb/testsuite/gdb.mi/mi-break.exp | 8 ++ gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp | 2 + .../gdb.trace/mi-trace-frame-collected.exp | 4 +- gdb/testsuite/gdb.trace/mi-trace-unavailable.exp | 4 +- gdb/tracepoint.c | 2 +- 13 files changed, 167 insertions(+), 78 deletions(-) -- 1.7.7.6