From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PUSHED] inf-child.c: Update comments.
Date: Wed, 12 Mar 2014 11:52:00 -0000 [thread overview]
Message-ID: <1394625117-10939-1-git-send-email-palves@redhat.com> (raw)
This file is no longer used exclusively by Unix targets anymore.
gdb/
2014-03-12 Pedro Alves <palves@redhat.com>
* inf-child.c: Update top comment to not mention Unix. Add
generic comment describing how this target is meant to be used.
(inf_child_post_attach, inf_child_post_startup_inferior)
(inf_child_follow_fork, inf_child_pid_to_exec_file): Don't mention
Unix in comment.
---
gdb/ChangeLog | 8 ++++++++
gdb/inf-child.c | 23 +++++++++++++----------
2 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index abfbfd7..f8d9d05 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,13 @@
2014-03-12 Pedro Alves <palves@redhat.com>
+ * inf-child.c: Update top comment to not mention Unix. Add
+ generic comment describing how this target is meant to be used.
+ (inf_child_post_attach, inf_child_post_startup_inferior)
+ (inf_child_follow_fork, inf_child_pid_to_exec_file): Don't mention
+ Unix in comment.
+
+2014-03-12 Pedro Alves <palves@redhat.com>
+
* nto-procfs.c: Include inf-child.h.
(procfs_ops): Delete global.
(procfs_can_run): Delete method.
diff --git a/gdb/inf-child.c b/gdb/inf-child.c
index fd03a9f..ee63dd1 100644
--- a/gdb/inf-child.c
+++ b/gdb/inf-child.c
@@ -1,5 +1,4 @@
-/* Default child (native) target interface, for GDB when running under
- Unix.
+/* Base/prototype target for default child (native) targets.
Copyright (C) 1988-2014 Free Software Foundation, Inc.
@@ -18,6 +17,11 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
+/* This file provides a common base class/target that all native
+ target implementations extend, by calling inf_child_target to get a
+ new prototype target and then overriding target methods as
+ necessary. */
+
#include "defs.h"
#include "regcache.h"
#include "memattr.h"
@@ -89,8 +93,8 @@ inf_child_store_inferior_registers (struct target_ops *ops,
static void
inf_child_post_attach (struct target_ops *self, int pid)
{
- /* This version of Unix doesn't require a meaningful "post attach"
- operation by a debugger. */
+ /* This target doesn't require a meaningful "post attach" operation
+ by a debugger. */
}
/* Get ready to modify the registers array. On machines which store
@@ -114,16 +118,15 @@ inf_child_open (char *arg, int from_tty)
static void
inf_child_post_startup_inferior (struct target_ops *self, ptid_t ptid)
{
- /* This version of Unix doesn't require a meaningful "post startup
- inferior" operation by a debugger. */
+ /* This target doesn't require a meaningful "post startup inferior"
+ operation by a debugger. */
}
static int
inf_child_follow_fork (struct target_ops *ops, int follow_child,
int detach_fork)
{
- /* This version of Unix doesn't support following fork or vfork
- events. */
+ /* This target doesn't support following fork or vfork events. */
return 0;
}
@@ -136,8 +139,8 @@ inf_child_can_run (struct target_ops *self)
static char *
inf_child_pid_to_exec_file (struct target_ops *self, int pid)
{
- /* This version of Unix doesn't support translation of a process ID
- to the filename of the executable file. */
+ /* This target doesn't support translation of a process ID to the
+ filename of the executable file. */
return NULL;
}
--
1.7.11.7
next reply other threads:[~2014-03-12 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 11:52 Pedro Alves [this message]
2014-03-12 12:34 ` Agovic, Sanimir
2014-03-12 12:40 ` Pedro Alves
2014-03-12 13:37 ` [PATCH] inf-child.h: Update comment Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394625117-10939-1-git-send-email-palves@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox