Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Cc: nickc@redhat.com
Subject: [PATCH 1/3] sim: msp430: fix build time warnings
Date: Sat, 08 Mar 2014 05:28:00 -0000	[thread overview]
Message-ID: <1394256493-15084-1-git-send-email-vapier@gentoo.org> (raw)

This fix is simple:

msp430-sim.c: In function 'maybe_perform_syscall':
msp430-sim.c:898:10: warning: format '%d' expects argument of type 'int',
                     but argument 5 has type 'long int' [-Wformat]

This one we change to use casts like everyone else does in the code base:

msp430-sim.c: In function 'msp430_step_once':
msp430-sim.c:985:7: warning: passing argument 3 of 'init_disassemble_info'
                    from incompatible pointer type [enabled by default]
include/dis-asm.h:368:13: note: expected 'fprintf_ftype' but argument is
of type 'int (*)(struct FILE * __restrict__,  const char * __restrict__)'

2014-03-08  Mike Frysinger  <vapier@gentoo.org>

	* msp430-sim (maybe_perform_syscall): Change %d to %ld.
	(msp430_step_once): Cast fprintf to fprintf_ftype.
---
 sim/msp430/msp430-sim.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sim/msp430/msp430-sim.c b/sim/msp430/msp430-sim.c
index 8cd2e1e..c3fa4a9 100644
--- a/sim/msp430/msp430-sim.c
+++ b/sim/msp430/msp430-sim.c
@@ -895,7 +895,7 @@ maybe_perform_syscall (SIM_DESC sd, int call_addr)
 
       if (TRACE_SYSCALL_P (MSP430_CPU (sd)))
 	trace_generic (sd, MSP430_CPU (sd), TRACE_SYSCALL_IDX,
-		       "returns %d", sc.result);
+		       "returns %ld", sc.result);
 
       MSP430_CPU (sd)->state.regs[12] = sc.result;
       return 1;
@@ -982,7 +982,7 @@ msp430_step_once (SIM_DESC sd)
 
       sim_core_read_buffer (sd, MSP430_CPU (sd), 0, b, opcode_pc, opsize);
 
-      init_disassemble_info (&info, stderr, fprintf);
+      init_disassemble_info (&info, stderr, (fprintf_ftype) fprintf);
       info.private_data = sd;
       info.read_memory_func = msp430_dis_read;
       fprintf (stderr, "%#8x  ", opcode_pc);
-- 
1.9.0


             reply	other threads:[~2014-03-08  5:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-08  5:28 Mike Frysinger [this message]
2014-03-08  5:28 ` [PATCH 2/3] sim: msp430: set initial PC to ELF entry if available Mike Frysinger
2014-03-10 13:19   ` Nicholas Clifton
2014-03-10 21:09   ` DJ Delorie
2014-03-10 22:28     ` Mike Frysinger
2014-03-11  3:38   ` [PATCH v2] " Mike Frysinger
2014-03-11  3:44     ` DJ Delorie
2014-03-11  3:57       ` Mike Frysinger
2014-03-11  4:12         ` DJ Delorie
2014-03-08  5:28 ` [PATCH 3/3] sim: msp430: start a test framework Mike Frysinger
2014-03-10 13:56   ` Nicholas Clifton
2014-03-10 13:18 ` [PATCH 1/3] sim: msp430: fix build time warnings Nicholas Clifton
2014-03-10 19:30   ` Mike Frysinger
2014-03-11 16:08     ` Nicholas Clifton
2014-03-11 19:01       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394256493-15084-1-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox