From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20652 invoked by alias); 7 Feb 2014 08:01:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20437 invoked by uid 89); 7 Feb 2014 08:01:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Feb 2014 08:01:38 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WBgNT-0002LP-17 from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Fri, 07 Feb 2014 00:01:35 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 7 Feb 2014 00:01:34 -0800 Received: from qiyao.dyndns.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Fri, 7 Feb 2014 00:01:33 -0800 From: Yao Qi To: Subject: [PATCH 2/3] Fix -Werror=pointer-sign warnings Date: Fri, 07 Feb 2014 08:01:00 -0000 Message-ID: <1391759958-972-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1391759958-972-1-git-send-email-yao@codesourcery.com> References: <1391759958-972-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00187.txt.bz2 ../../../git/gdb/gnu-nat.c: In function 'gnu_read_inferior': ../../../git/gdb/gnu-nat.c:2282:3: error: pointer targets in passing argument 5 of 'vm_read' differ in signedness [-Werror=pointer-sign] In file included from /home/yao/Software/hurd-toolchain/bin/../i686-pc-gnu/libc/usr/include/mach.h:38:0, from ./nm.h:23, from ../../../git/gdb/defs.h:500, from ../../../git/gdb/gnu-nat.c:23: /home/yao/Software/hurd-toolchain/bin/../i686-pc-gnu/libc/usr/include/mach/mach_interface.h:843:15: note: expected 'mach_msg_type_number_t *' but argument is of type 'int *' ../../../git/gdb/gnu-nat.c: In function 'gnu_write_inferior': ../../../git/gdb/gnu-nat.c:2339:4: error: pointer targets in passing argument 5 of 'vm_read' differ in signedness [-Werror=pointer-sign] In file included from /home/yao/Software/hurd-toolchain/bin/../i686-pc-gnu/libc/usr/include/mach.h:38:0, from ./nm.h:23, from ../../../git/gdb/defs.h:500, from ../../../git/gdb/gnu-nat.c:23: /home/yao/Software/hurd-toolchain/bin/../i686-pc-gnu/libc/usr/include/mach/mach_interface.h:843:15: note: expected 'mach_msg_type_number_t *' but argument is of type 'int *' This patch fixes these warnings. gdb: 2014-02-07 Yao Qi * gnu-nat.c (gnu_read_inferior): Change 'copy_count' type to mach_msg_type_number_t. (gnu_write_inferior): Likewise. --- gdb/gnu-nat.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index 6e65446..d5ce416 100644 --- a/gdb/gnu-nat.c +++ b/gdb/gnu-nat.c @@ -2276,7 +2276,7 @@ gnu_read_inferior (task_t task, CORE_ADDR addr, gdb_byte *myaddr, int length) vm_size_t aligned_length = (vm_size_t) round_page (addr + length) - low_address; pointer_t copied; - int copy_count; + mach_msg_type_number_t copy_count; /* Get memory from inferior with page aligned addresses. */ err = vm_read (task, low_address, aligned_length, &copied, ©_count); @@ -2323,7 +2323,7 @@ gnu_write_inferior (task_t task, CORE_ADDR addr, vm_size_t aligned_length = (vm_size_t) round_page (addr + length) - low_address; pointer_t copied; - int copy_count; + mach_msg_type_number_t copy_count; int deallocate = 0; char *errstr = "Bug in gnu_write_inferior"; -- 1.7.7.6