From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17165 invoked by alias); 6 Feb 2014 20:56:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17007 invoked by uid 89); 6 Feb 2014 20:56:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2014 20:56:15 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s16KuCkB001576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Feb 2014 15:56:12 -0500 Received: from barimba.redhat.com (ovpn-113-148.phx2.redhat.com [10.3.113.148]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s16KtfZw013306; Thu, 6 Feb 2014 15:56:11 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFC v2 37/38] fix buglet in nto-procfs.c Date: Thu, 06 Feb 2014 20:56:00 -0000 Message-Id: <1391720136-2121-38-git-send-email-tromey@redhat.com> In-Reply-To: <1391720136-2121-1-git-send-email-tromey@redhat.com> References: <1391720136-2121-1-git-send-email-tromey@redhat.com> X-SW-Source: 2014-02/txt/msg00157.txt.bz2 I happened to notice that nto-procfs.c defines procfs_remove_hw_breakpoint but never uses it. This caused it not to be updated by my target-method-updating script. This patch fixes the function and installs it properly. I have no way to test this, however. 2014-02-06 Tom Tromey * nto-procfs.c (procfs_remove_hw_breakpoint): Add 'self' argument. (init_procfs_ops): Correctly set to_remove_hw_breakpoint. --- gdb/ChangeLog | 6 ++++++ gdb/nto-procfs.c | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c index 1b2b2ff..d0bdc90 100644 --- a/gdb/nto-procfs.c +++ b/gdb/nto-procfs.c @@ -947,7 +947,8 @@ procfs_insert_hw_breakpoint (struct target_ops *self, struct gdbarch *gdbarch, } static int -procfs_remove_hw_breakpoint (struct gdbarch *gdbarch, +procfs_remove_hw_breakpoint (struct target_ops *self, + struct gdbarch *gdbarch, struct bp_target_info *bp_tgt) { return procfs_breakpoint (bp_tgt->placed_address, @@ -1402,7 +1403,7 @@ init_procfs_ops (void) procfs_ops.to_remove_breakpoint = procfs_remove_breakpoint; procfs_ops.to_can_use_hw_breakpoint = procfs_can_use_hw_breakpoint; procfs_ops.to_insert_hw_breakpoint = procfs_insert_hw_breakpoint; - procfs_ops.to_remove_hw_breakpoint = procfs_remove_breakpoint; + procfs_ops.to_remove_hw_breakpoint = procfs_remove_hw_breakpoint; procfs_ops.to_insert_watchpoint = procfs_insert_hw_watchpoint; procfs_ops.to_remove_watchpoint = procfs_remove_hw_watchpoint; procfs_ops.to_stopped_by_watchpoint = procfs_stopped_by_watchpoint; -- 1.8.1.4