From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30167 invoked by alias); 6 Feb 2014 21:38:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30158 invoked by uid 89); 6 Feb 2014 21:38:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2014 21:38:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s16KuAeV006675 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Feb 2014 15:56:10 -0500 Received: from barimba.redhat.com (ovpn-113-148.phx2.redhat.com [10.3.113.148]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s16KtfZs013306; Thu, 6 Feb 2014 15:56:09 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFC v2 33/38] pass NULL to TARGET_DEFAULT_RETURN when appropriate Date: Thu, 06 Feb 2014 21:38:00 -0000 Message-Id: <1391720136-2121-34-git-send-email-tromey@redhat.com> In-Reply-To: <1391720136-2121-1-git-send-email-tromey@redhat.com> References: <1391720136-2121-1-git-send-email-tromey@redhat.com> X-SW-Source: 2014-02/txt/msg00174.txt.bz2 This changes instances of TARGET_DEFAULT_RETURN(0) to TARGET_DEFAULT_RETURN(NULL) when appropriate. The use of "0" was a relic from an earlier implementation of make-target-delegates; and I didn't want to go back through the long patch series, fixing up conflicts, just to change this small detail. 2014-02-06 Tom Tromey * target-delegates.c: Rebuild. * target.h (struct target_ops) : Use NULL, not 0, in TARGET_DEFAULT_RETURN. --- gdb/ChangeLog | 8 ++++++++ gdb/target-delegates.c | 14 +++++++------- gdb/target.h | 14 +++++++------- 3 files changed, 22 insertions(+), 14 deletions(-) diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c index ae5a796..78e3c0d 100644 --- a/gdb/target-delegates.c +++ b/gdb/target-delegates.c @@ -609,7 +609,7 @@ delegate_extra_thread_info (struct target_ops *self, struct thread_info *arg1) static char * tdefault_extra_thread_info (struct target_ops *self, struct thread_info *arg1) { - return 0; + return NULL; } static char * @@ -622,7 +622,7 @@ delegate_thread_name (struct target_ops *self, struct thread_info *arg1) static char * tdefault_thread_name (struct target_ops *self, struct thread_info *arg1) { - return 0; + return NULL; } static void @@ -654,7 +654,7 @@ delegate_pid_to_exec_file (struct target_ops *self, int arg1) static char * tdefault_pid_to_exec_file (struct target_ops *self, int arg1) { - return 0; + return NULL; } static void @@ -679,7 +679,7 @@ delegate_get_section_table (struct target_ops *self) static struct target_section_table * tdefault_get_section_table (struct target_ops *self) { - return 0; + return NULL; } static int @@ -772,7 +772,7 @@ delegate_memory_map (struct target_ops *self) static VEC(mem_region_s) * tdefault_memory_map (struct target_ops *self) { - return 0; + return NULL; } static void @@ -811,7 +811,7 @@ delegate_read_description (struct target_ops *self) static const struct target_desc * tdefault_read_description (struct target_ops *self) { - return 0; + return NULL; } static ptid_t @@ -1297,7 +1297,7 @@ delegate_traceframe_info (struct target_ops *self) static struct traceframe_info * tdefault_traceframe_info (struct target_ops *self) { - return 0; + return NULL; } static int diff --git a/gdb/target.h b/gdb/target.h index 853db76..09fe10e 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -558,20 +558,20 @@ struct target_ops char *(*to_pid_to_str) (struct target_ops *, ptid_t) TARGET_DEFAULT_FUNC (default_pid_to_str); char *(*to_extra_thread_info) (struct target_ops *, struct thread_info *) - TARGET_DEFAULT_RETURN (0); + TARGET_DEFAULT_RETURN (NULL); char *(*to_thread_name) (struct target_ops *, struct thread_info *) - TARGET_DEFAULT_RETURN (0); + TARGET_DEFAULT_RETURN (NULL); void (*to_stop) (struct target_ops *, ptid_t) TARGET_DEFAULT_IGNORE (); void (*to_rcmd) (struct target_ops *, char *command, struct ui_file *output) TARGET_DEFAULT_FUNC (default_rcmd); char *(*to_pid_to_exec_file) (struct target_ops *, int pid) - TARGET_DEFAULT_RETURN (0); + TARGET_DEFAULT_RETURN (NULL); void (*to_log_command) (struct target_ops *, const char *) TARGET_DEFAULT_IGNORE (); struct target_section_table *(*to_get_section_table) (struct target_ops *) - TARGET_DEFAULT_RETURN (0); + TARGET_DEFAULT_RETURN (NULL); enum strata to_stratum; int (*to_has_all_memory) (struct target_ops *); int (*to_has_memory) (struct target_ops *); @@ -659,7 +659,7 @@ struct target_ops change unexpectedly, it should be invalidated, and higher layers will re-fetch it. */ VEC(mem_region_s) *(*to_memory_map) (struct target_ops *) - TARGET_DEFAULT_RETURN (0); + TARGET_DEFAULT_RETURN (NULL); /* Erases the region of flash memory starting at ADDRESS, of length LENGTH. @@ -682,7 +682,7 @@ struct target_ops "beneath" target. Returns the description found, or NULL if no description was available. */ const struct target_desc *(*to_read_description) (struct target_ops *ops) - TARGET_DEFAULT_RETURN (0); + TARGET_DEFAULT_RETURN (NULL); /* Build the PTID of the thread on which a given task is running, based on LWP and THREAD. These values are extracted from the @@ -974,7 +974,7 @@ struct target_ops cache data; higher layers take care of caching, invalidating, and re-fetching when necessary. */ struct traceframe_info *(*to_traceframe_info) (struct target_ops *) - TARGET_DEFAULT_RETURN (0); + TARGET_DEFAULT_RETURN (NULL); /* Ask the target to use or not to use agent according to USE. Return 1 successful, 0 otherwise. */ -- 1.8.1.4