Re: [PATCH 2/6] core_xfer_shared_libraries and core_xfer_shared_libraries_aix returns ULONGEST

Pedro Alves
2014-02-06T14:43:29Z

On 01/31/2014 03:35 AM, Yao Qi wrote:
> This patch specifies the return value of core_xfer_shared_libraries_aix
> and core_xfer_shared_libraries, and change return value to ULONGEST.
>
> The following patch can check its return value in core_xfer_partial
> and return appropriate target_xfer_status in core_xfer_partial.

I got a little confused reading this. I suggest:

This patch documents the return value of core_xfer_shared_libraries_aix
and core_xfer_shared_libraries gdbarch hooks, and changes their return
type to ULONGEST from LONGEST.

In a following patch, core_xfer_partial is changed to check their
return values and return an appropriate target_xfer_status.

> # Read offset OFFSET of TARGET_OBJECT_LIBRARIES formatted shared libraries list from
> -# core file into buffer READBUF with length LEN.
> -M:LONGEST:core_xfer_shared_libraries:gdb_byte *readbuf, ULONGEST offset, ULONGEST len:readbuf, offset, len
> +# core file into buffer READBUF with length LEN. Return the number of bytes read (
> +# zero indicates failure).

Nit, please put the opening '(' on the next line. Looks a little odd to me
that way. Like:

> +# core file into buffer READBUF with length LEN. Return the number of bytes read
> +# (zero indicates failure).

Otherwise OK.

Thanks,
--
Pedro Alves