From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18164 invoked by alias); 31 Jan 2014 03:38:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18152 invoked by uid 89); 31 Jan 2014 03:38:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Jan 2014 03:38:56 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1W94wP-0002d4-EA from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 30 Jan 2014 19:38:53 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 30 Jan 2014 19:38:53 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Thu, 30 Jan 2014 19:38:51 -0800 From: Yao Qi To: Subject: [PATCH 6/6] Update comments to to_xfer_partial implementations. Date: Fri, 31 Jan 2014 03:38:00 -0000 Message-ID: <1391139325-2758-7-git-send-email-yao@codesourcery.com> In-Reply-To: <1391139325-2758-1-git-send-email-yao@codesourcery.com> References: <1391139325-2758-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg01070.txt.bz2 Some comments to to_xfer_partial implementations are out of date. This patch updates them using the "Implement the to_xfer_partial target_ops method" pattern. gdb: 2014-01-30 Yao Qi * aix-thread.c (aix_thread_xfer_partial): Update comments. * auxv.c (procfs_xfer_auxv, memory_xfer_auxv): Likewise. * bsd-uthread.c (bsd_uthread_xfer_partial): Likewise. * gnu-nat.c (gnu_xfer_memory): Likewise. * inf-ptrace.c (inf_ptrace_xfer_partial): Likewise. * rs6000-nat.c (rs6000_xfer_partial): Likewise. * sparc-nat.c (sparc_xfer_wcookie): Likewise. * spu-linux-nat.c (spu_proc_xfer_spu): Likewise. --- gdb/aix-thread.c | 4 +--- gdb/auxv.c | 9 +++++---- gdb/bsd-uthread.c | 5 +++-- gdb/gnu-nat.c | 3 ++- gdb/inf-ptrace.c | 4 +--- gdb/rs6000-nat.c | 5 +---- gdb/sparc-nat.c | 3 ++- gdb/spu-linux-nat.c | 4 +++- 8 files changed, 18 insertions(+), 19 deletions(-) diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c index 4feb0cb..bd2a3a1 100644 --- a/gdb/aix-thread.c +++ b/gdb/aix-thread.c @@ -1678,9 +1678,7 @@ aix_thread_store_registers (struct target_ops *ops, } } -/* Attempt a transfer all LEN bytes starting at OFFSET between the - inferior's OBJECT:ANNEX space and GDB's READBUF/WRITEBUF buffer. - Return the number of bytes actually transferred. */ +/* Implement the to_xfer_partial target_ops method. */ static enum target_xfer_status aix_thread_xfer_partial (struct target_ops *ops, enum target_object object, diff --git a/gdb/auxv.c b/gdb/auxv.c index 50009d8..4886992 100644 --- a/gdb/auxv.c +++ b/gdb/auxv.c @@ -35,8 +35,9 @@ #include -/* This function handles access via /proc/PID/auxv, which is a common - method for native targets. */ +/* Implement the to_xfer_partial target_ops method. This function + handles access via /proc/PID/auxv, which is a common method for + native targets. */ static enum target_xfer_status procfs_xfer_auxv (gdb_byte *readbuf, @@ -215,8 +216,8 @@ ld_so_xfer_auxv (gdb_byte *readbuf, return TARGET_XFER_OK; } -/* This function is called like a to_xfer_partial hook, but must be - called with TARGET_OBJECT_AUXV. It handles access to AUXV. */ +/* Implement the to_xfer_partial target_ops method for + TARGET_OBJECT_AUXV. It handles access to AUXV. */ enum target_xfer_status memory_xfer_auxv (struct target_ops *ops, diff --git a/gdb/bsd-uthread.c b/gdb/bsd-uthread.c index 446bbd2..bf6c390 100644 --- a/gdb/bsd-uthread.c +++ b/gdb/bsd-uthread.c @@ -331,8 +331,9 @@ bsd_uthread_store_registers (struct target_ops *ops, } } -/* FIXME: This function is only there because otherwise GDB tries to - invoke deprecate_xfer_memory. */ +/* Implement the to_xfer_partial target_ops method. FIXME: This + function is only there because otherwise GDB tries to invoke + deprecate_xfer_memory. */ static enum target_xfer_status bsd_uthread_xfer_partial (struct target_ops *ops, enum target_object object, diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index b5a8da0..efafc35 100644 --- a/gdb/gnu-nat.c +++ b/gdb/gnu-nat.c @@ -2473,7 +2473,8 @@ out: -/* Helper for gnu_xfer_partial that handles memory transfers. */ +/* Implement the to_xfer_partial target_ops method for + TARGET_OBJECT_MEMORY. */ static enum target_xfer_status gnu_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf, diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c index 0876366..85e7e65 100644 --- a/gdb/inf-ptrace.c +++ b/gdb/inf-ptrace.c @@ -455,9 +455,7 @@ inf_ptrace_wait (struct target_ops *ops, return pid_to_ptid (pid); } -/* Attempt a transfer all LEN bytes starting at OFFSET between the - inferior's OBJECT:ANNEX space and GDB's READBUF/WRITEBUF buffer. - Return the number of bytes actually transferred. */ +/* Implement the to_xfer_partial target_ops method. */ static enum target_xfer_status inf_ptrace_xfer_partial (struct target_ops *ops, enum target_object object, diff --git a/gdb/rs6000-nat.c b/gdb/rs6000-nat.c index dfd59d9..606da52 100644 --- a/gdb/rs6000-nat.c +++ b/gdb/rs6000-nat.c @@ -374,10 +374,7 @@ rs6000_store_inferior_registers (struct target_ops *ops, } } - -/* Attempt a transfer all LEN bytes starting at OFFSET between the - inferior's OBJECT:ANNEX space and GDB's READBUF/WRITEBUF buffer. - Return the number of bytes actually transferred. */ +/* Implement the to_xfer_partial target_ops method. */ static enum target_xfer_status rs6000_xfer_partial (struct target_ops *ops, enum target_object object, diff --git a/gdb/sparc-nat.c b/gdb/sparc-nat.c index f29b4e9..a03c093 100644 --- a/gdb/sparc-nat.c +++ b/gdb/sparc-nat.c @@ -256,7 +256,8 @@ sparc_store_inferior_registers (struct target_ops *ops, } -/* Fetch StackGhost Per-Process XOR cookie. */ +/* Implement the to_xfer_partial target_ops method for + TARGET_OBJECT_WCOOKIE. Fetch StackGhost Per-Process XOR cookie. */ static enum target_xfer_status sparc_xfer_wcookie (struct target_ops *ops, enum target_object object, diff --git a/gdb/spu-linux-nat.c b/gdb/spu-linux-nat.c index 105529d..0127fd5 100644 --- a/gdb/spu-linux-nat.c +++ b/gdb/spu-linux-nat.c @@ -226,8 +226,10 @@ parse_spufs_run (int *fd, ULONGEST *addr) } -/* Copy LEN bytes at OFFSET in spufs file ANNEX into/from READBUF or WRITEBUF, +/* Implement the to_xfer_partial target_ops method for TARGET_OBJECT_SPU. + Copy LEN bytes at OFFSET in spufs file ANNEX into/from READBUF or WRITEBUF, using the /proc file system. */ + static enum target_xfer_status spu_proc_xfer_spu (const char *annex, gdb_byte *readbuf, const gdb_byte *writebuf, -- 1.7.7.6