Re: [PATCH 2/5] Query supported notifications by qSupported

Eli Zaretskii
2013-02-16T09:33:09Z

> From: Yao Qi <yao@codesourcery.com>
> Date: Sat, 16 Feb 2013 12:00:11 +0800
>
> As we we adding more notifications and annexes, both GDB and GDBserver
> has to know what notifications and annexes are supported in the other
> side. This is what this patch does. When GDB connects to GDBserver,
> it will happen:
>
> --> qSupported:XXX;notifications=N1,N2.A1.A2,N3
> (GDB supports notification N1, N2 with annexes A1,A2, and N3)

This form is not described in your patch for the manual.

> +@item notifications
> +@anchor{notifications feature}
> +This feature indicates that @value{GDBN} supports the async remote
> +notifications (@pxref{Notification Packets}). If the stub sees
> +@samp{notifications=} with a string of supported notifications,
> +separated by commas, it will report notifications supported by the
> +stub.

See above: I think you should show here the form of the
"notifications=" part in more detail. In particular, the fact that
each notification is of the form NOTIFICATION.ANNEX1.ANNEX2... is
important and should be described and the meaning of the multiple
ANNEX parts explained.

> +@item Notifications=@var{name}@r{[}.@var{annex}@r{]}@dots{}@r{[},@var{name}@r{[}.@var{annex}@r{]}@dots{}@r{]}@dots{}
> +@cindex notifications, in remote protocol
> +The remote stub supports a string of notifications. @var{name} is
> +the name of the notification and @var{annex} is the name of the annex,
> +if the notification has the annex.

Here, too, we should say explicitly that there could be several
@var{annex} parts separated by periods.

OK with those changes.

Thanks.