From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20908 invoked by alias); 21 Jan 2014 01:43:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20897 invoked by uid 89); 21 Jan 2014 01:43:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f51.google.com Received: from mail-pa0-f51.google.com (HELO mail-pa0-f51.google.com) (209.85.220.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 21 Jan 2014 01:43:47 +0000 Received: by mail-pa0-f51.google.com with SMTP id ld10so5436713pab.10 for ; Mon, 20 Jan 2014 17:43:45 -0800 (PST) X-Received: by 10.67.14.231 with SMTP id fj7mr21295396pad.115.1390268625351; Mon, 20 Jan 2014 17:43:45 -0800 (PST) Received: from ubuntu.dhcp.ucweb.local ([70.39.187.196]) by mx.google.com with ESMTPSA id vg1sm7049101pbc.44.2014.01.20.17.43.42 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 20 Jan 2014 17:43:44 -0800 (PST) From: manjian2006@gmail.com To: gdb-patches@sourceware.org, tromey@redhat.com Cc: linzj Subject: [PATCH] fixed inherit_abstract_dies infinite recursive call Date: Tue, 21 Jan 2014 01:43:00 -0000 Message-Id: <1390268608-16913-1-git-send-email-manjian2006@gmail.com> In-Reply-To: <87wqhvi4gs.fsf@fleche.redhat.com> References: <87wqhvi4gs.fsf@fleche.redhat.com> X-SW-Source: 2014-01/txt/msg00798.txt.bz2 From: linzj The c++ code causing the problem is: // Integer variants of certain metrics, used for HTML rendering. int ascent(FontBaseline baselineType = AlphabeticBaseline) const { if (baselineType == AlphabeticBaseline) return lroundf(m_ascent); return height() - height() / 2; } int height(FontBaseline baselineType = AlphabeticBaseline) const { return ascent(baselineType) + descent(baselineType); } As you can see,ascent(0x5816d55) calls height(0x5812c1b),and height calls ascent(0x5816d55) recursivly.And the compiler generates these dwarf code representing this relationship preciously. >> A dwarf die may have the following relationship: >> 564860c<----------------------------- >> | | >> |(abstract origin) | >> | | >> V | >> 5816d55 | (abstract origin) >> | | >> |(child) | >> | | >> V | >> ... | >> 5812c34------------------------------ >> So inherit_abstract_dies may results in infinite recursive call. >> A bit field call in_process has been add to struct die_info to fix this problem. >> process_die would first check if a die is in processing state, if so,just return. >> Then in_process bit is set.Before process_die returns,this bit field is unset. --- gdb/dwarf2read.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 7ca527d..c226a52 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -1224,6 +1224,8 @@ struct die_info /* True if we're presently building the full type name for the type derived from this DIE. */ unsigned char building_fullname : 1; + /* True if this die is in process. */ + unsigned char in_process : 1; /* Abbrev number */ unsigned int abbrev; @@ -8013,6 +8015,10 @@ process_imported_unit_die (struct die_info *die, struct dwarf2_cu *cu) static void process_die (struct die_info *die, struct dwarf2_cu *cu) { + /* Only process those who are not in process. */ + if (die->in_process) + return; + die->in_process = 1; switch (die->tag) { case DW_TAG_padding: @@ -8100,6 +8106,7 @@ process_die (struct die_info *die, struct dwarf2_cu *cu) new_symbol (die, NULL, cu); break; } + die->in_process = 0; } /* DWARF name computation. */ -- 1.8.3.2