From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27652 invoked by alias); 20 Jan 2014 19:18:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27550 invoked by uid 89); 20 Jan 2014 19:18:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Jan 2014 19:18:27 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0KJIPmX004814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Jan 2014 14:18:25 -0500 Received: from barimba.redhat.com (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0KJINCt031799; Mon, 20 Jan 2014 14:18:25 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFC 3/9] don't let bin2hex call strlen Date: Mon, 20 Jan 2014 19:18:00 -0000 Message-Id: <1390245501-1186-4-git-send-email-tromey@redhat.com> In-Reply-To: <1390245501-1186-1-git-send-email-tromey@redhat.com> References: <1390245501-1186-1-git-send-email-tromey@redhat.com> X-SW-Source: 2014-01/txt/msg00751.txt.bz2 Currently bin2hex may call strlen if the length argument is zero. This prevents some function unification; and also it seems cleaner to me not to have a special meaning for a zero length. 2014-01-20 Tom Tromey * common/rsp-low.c (bin2hex): Never take strlen of argument. * remote.c (extended_remote_run, remote_rcmd) (remote_download_trace_state_variable, remote_save_trace_data) (remote_set_trace_notes): Update. * tracepoint.c (encode_source_string, tfile_write_status) (tfile_write_uploaded_tsv): Update. --- gdb/ChangeLog | 9 +++++++++ gdb/common/rsp-low.c | 4 ---- gdb/remote.c | 18 ++++++++++-------- gdb/tracepoint.c | 10 +++++----- 4 files changed, 24 insertions(+), 17 deletions(-) diff --git a/gdb/common/rsp-low.c b/gdb/common/rsp-low.c index 0e3da39..9c5119b 100644 --- a/gdb/common/rsp-low.c +++ b/gdb/common/rsp-low.c @@ -163,10 +163,6 @@ bin2hex (const gdb_byte *bin, char *hex, int count) { int i; - /* May use a length, or a nul-terminated string as input. */ - if (count == 0) - count = strlen ((char *) bin); - for (i = 0; i < count; i++) { *hex++ = tohex ((*bin >> 4) & 0xf); diff --git a/gdb/remote.c b/gdb/remote.c index 881a203..fe4a9f5 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -7864,7 +7864,8 @@ extended_remote_run (char *args) if (strlen (remote_exec_file) * 2 + len >= get_remote_packet_size ()) error (_("Remote file name too long for run packet")); - len += 2 * bin2hex ((gdb_byte *) remote_exec_file, rs->buf + len, 0); + len += 2 * bin2hex ((gdb_byte *) remote_exec_file, rs->buf + len, + strlen (remote_exec_file)); gdb_assert (args != NULL); if (*args) @@ -7880,7 +7881,8 @@ extended_remote_run (char *args) if (strlen (argv[i]) * 2 + 1 + len >= get_remote_packet_size ()) error (_("Argument list too long for run packet")); rs->buf[len++] = ';'; - len += 2 * bin2hex ((gdb_byte *) argv[i], rs->buf + len, 0); + len += 2 * bin2hex ((gdb_byte *) argv[i], rs->buf + len, + strlen (argv[i])); } do_cleanups (back_to); } @@ -8955,7 +8957,7 @@ remote_rcmd (char *command, error (_("\"monitor\" command ``%s'' is too long."), command); /* Encode the actual command. */ - bin2hex ((gdb_byte *) command, p, 0); + bin2hex ((gdb_byte *) command, p, strlen (command)); if (putpkt (rs->buf) < 0) error (_("Communication problem with target.")); @@ -10572,7 +10574,7 @@ remote_download_trace_state_variable (struct trace_state_variable *tsv) p = rs->buf + strlen (rs->buf); if ((p - rs->buf) + strlen (tsv->name) * 2 >= get_remote_packet_size ()) error (_("Trace state variable name too long for tsv definition packet")); - p += 2 * bin2hex ((gdb_byte *) (tsv->name), p, 0); + p += 2 * bin2hex ((gdb_byte *) (tsv->name), p, strlen (tsv->name)); *p++ = '\0'; putpkt (rs->buf); remote_get_noisy_reply (&target_buf, &target_buf_size); @@ -10902,7 +10904,7 @@ remote_save_trace_data (const char *filename) p += strlen (p); if ((p - rs->buf) + strlen (filename) * 2 >= get_remote_packet_size ()) error (_("Remote file name too long for trace save packet")); - p += 2 * bin2hex ((gdb_byte *) filename, p, 0); + p += 2 * bin2hex ((gdb_byte *) filename, p, strlen (filename)); *p++ = '\0'; putpkt (rs->buf); reply = remote_get_noisy_reply (&target_buf, &target_buf_size); @@ -11107,21 +11109,21 @@ remote_set_trace_notes (const char *user, const char *notes, if (user) { buf += xsnprintf (buf, endbuf - buf, "user:"); - nbytes = bin2hex ((gdb_byte *) user, buf, 0); + nbytes = bin2hex ((gdb_byte *) user, buf, strlen (user)); buf += 2 * nbytes; *buf++ = ';'; } if (notes) { buf += xsnprintf (buf, endbuf - buf, "notes:"); - nbytes = bin2hex ((gdb_byte *) notes, buf, 0); + nbytes = bin2hex ((gdb_byte *) notes, buf, strlen (notes)); buf += 2 * nbytes; *buf++ = ';'; } if (stop_notes) { buf += xsnprintf (buf, endbuf - buf, "tstop:"); - nbytes = bin2hex ((gdb_byte *) stop_notes, buf, 0); + nbytes = bin2hex ((gdb_byte *) stop_notes, buf, strlen (stop_notes)); buf += 2 * nbytes; *buf++ = ';'; } diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c index 56bfb84..a2cadac 100644 --- a/gdb/tracepoint.c +++ b/gdb/tracepoint.c @@ -3090,7 +3090,7 @@ encode_source_string (int tpnum, ULONGEST addr, srctype, 0, (int) strlen (src)); if (strlen (buf) + strlen (src) * 2 >= buf_size) error (_("Source string too long for buffer")); - bin2hex ((gdb_byte *) src, buf + strlen (buf), 0); + bin2hex ((gdb_byte *) src, buf + strlen (buf), strlen (src)); return -1; } @@ -3209,7 +3209,7 @@ tfile_write_status (struct trace_file_writer *self, { char *buf = (char *) alloca (strlen (ts->stop_desc) * 2 + 1); - bin2hex ((gdb_byte *) ts->stop_desc, buf, 0); + bin2hex ((gdb_byte *) ts->stop_desc, buf, strlen (ts->stop_desc)); fprintf (writer->fp, ":%s", buf); } fprintf (writer->fp, ":%x", ts->stopping_tracepoint); @@ -3239,14 +3239,14 @@ tfile_write_status (struct trace_file_writer *self, { char *buf = (char *) alloca (strlen (ts->notes) * 2 + 1); - bin2hex ((gdb_byte *) ts->notes, buf, 0); + bin2hex ((gdb_byte *) ts->notes, buf, strlen (ts->notes)); fprintf (writer->fp, ";notes:%s", buf); } if (ts->user_name != NULL) { char *buf = (char *) alloca (strlen (ts->user_name) * 2 + 1); - bin2hex ((gdb_byte *) ts->user_name, buf, 0); + bin2hex ((gdb_byte *) ts->user_name, buf, strlen (ts->user_name)); fprintf (writer->fp, ";username:%s", buf); } fprintf (writer->fp, "\n"); @@ -3266,7 +3266,7 @@ tfile_write_uploaded_tsv (struct trace_file_writer *self, if (utsv->name) { buf = (char *) xmalloc (strlen (utsv->name) * 2 + 1); - bin2hex ((gdb_byte *) (utsv->name), buf, 0); + bin2hex ((gdb_byte *) (utsv->name), buf, strlen (utsv->name)); } fprintf (writer->fp, "tsv %x:%s:%x:%s\n", -- 1.8.1.4