From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 603 invoked by alias); 20 Jan 2014 19:23:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 505 invoked by uid 89); 20 Jan 2014 19:23:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Jan 2014 19:23:37 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0KJISIY020877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Jan 2014 14:18:28 -0500 Received: from barimba.redhat.com (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0KJIND1031799; Mon, 20 Jan 2014 14:18:28 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFC 9/9] update rsp-low comments Date: Mon, 20 Jan 2014 19:23:00 -0000 Message-Id: <1390245501-1186-10-git-send-email-tromey@redhat.com> In-Reply-To: <1390245501-1186-1-git-send-email-tromey@redhat.com> References: <1390245501-1186-1-git-send-email-tromey@redhat.com> X-SW-Source: 2014-01/txt/msg00754.txt.bz2 This updates all the comments in rsp-low.[ch], now that the unification has been completed. 2014-01-20 Tom Tromey * common/rsp-low.c: Update comments. * common/rsp-low.h: Update comments. --- gdb/ChangeLog | 5 +++++ gdb/common/rsp-low.c | 18 +++++++++++++++++- gdb/common/rsp-low.h | 21 +++++++++++++++++++++ 3 files changed, 43 insertions(+), 1 deletion(-) diff --git a/gdb/common/rsp-low.c b/gdb/common/rsp-low.c index d7a1280..d085bd7 100644 --- a/gdb/common/rsp-low.c +++ b/gdb/common/rsp-low.c @@ -27,7 +27,7 @@ #include "rsp-low.h" -/* Convert hex digit A to a number. */ +/* See rsp-low.h. */ int fromhex (int a) @@ -42,6 +42,8 @@ fromhex (int a) error (_("Reply contains invalid hex digit %d"), a); } +/* See rsp-low.h. */ + int tohex (int nib) { @@ -76,6 +78,8 @@ ishex (int ch, int *val) return 0; } +/* See rsp-low.h. */ + char * pack_nibble (char *buf, int nibble) { @@ -83,6 +87,8 @@ pack_nibble (char *buf, int nibble) return buf; } +/* See rsp-low.h. */ + char * pack_hex_byte (char *pkt, int byte) { @@ -91,6 +97,8 @@ pack_hex_byte (char *pkt, int byte) return pkt; } +/* See rsp-low.h. */ + char * unpack_varlen_hex (char *buff, /* packet to parse */ ULONGEST *result) @@ -108,6 +116,8 @@ unpack_varlen_hex (char *buff, /* packet to parse */ return buff; } +/* See rsp-low.h. */ + int hex2bin (const char *hex, gdb_byte *bin, int count) { @@ -127,6 +137,8 @@ hex2bin (const char *hex, gdb_byte *bin, int count) return i; } +/* See rsp-low.h. */ + int bin2hex (const gdb_byte *bin, char *hex, int count) { @@ -141,6 +153,8 @@ bin2hex (const gdb_byte *bin, char *hex, int count) return i; } +/* See rsp-low.h. */ + int remote_escape_output (const gdb_byte *buffer, int len, gdb_byte *out_buf, int *out_len, @@ -173,6 +187,8 @@ remote_escape_output (const gdb_byte *buffer, int len, return output_index; } +/* See rsp-low.h. */ + int remote_unescape_input (const gdb_byte *buffer, int len, gdb_byte *out_buf, int out_maxlen) diff --git a/gdb/common/rsp-low.h b/gdb/common/rsp-low.h index 611dba3..71d9dbc 100644 --- a/gdb/common/rsp-low.h +++ b/gdb/common/rsp-low.h @@ -28,14 +28,35 @@ extern int fromhex (int a); extern int tohex (int nib); +/* Write a character representing the low order four bits of NIBBLE in + hex to *BUF. Returns BUF+1. */ + extern char *pack_nibble (char *buf, int nibble); +/* Write the low byte of BYTE in hex to *BUF. Returns BUF+2. */ + extern char *pack_hex_byte (char *pkt, int byte); +/* Read hex digits from BUFF and convert to a number, which is stored + in RESULT. Reads until a non-hex digit is seen. Returns a pointer + to the terminating character. */ + extern char *unpack_varlen_hex (char *buff, ULONGEST *result); +/* HEX is a string of characters representing hexadecimal digits. + Convert pairs of hex digits to bytes and store sequentially into + BIN. COUNT is the maximum number of characters to convert. This + will convert fewer characters if the number of hex characters + actually seen is odd, or if HEX terminates before COUNT characters. + Returns the number of characters actually converted. */ + extern int hex2bin (const char *hex, gdb_byte *bin, int count); +/* Convert some bytes to a hexadecimal representation. BIN holds the + bytes to convert. COUNT says how many bytes to convert. The + resulting characters are stored in HEX, followed by a NUL + character. Returns the number of bytes actually converted. */ + extern int bin2hex (const gdb_byte *bin, char *hex, int count); /* Convert BUFFER, binary data at least LEN bytes long, into escaped -- 1.8.1.4