From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12886 invoked by alias); 20 Jan 2014 06:22:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12877 invoked by uid 89); 20 Jan 2014 06:22:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f46.google.com Received: from mail-pb0-f46.google.com (HELO mail-pb0-f46.google.com) (209.85.160.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 20 Jan 2014 06:22:07 +0000 Received: by mail-pb0-f46.google.com with SMTP id um1so1557500pbc.5 for ; Sun, 19 Jan 2014 22:22:05 -0800 (PST) X-Received: by 10.66.65.134 with SMTP id x6mr16674128pas.12.1390198925320; Sun, 19 Jan 2014 22:22:05 -0800 (PST) Received: from ubuntu.dhcp.ucweb.local ([70.39.187.196]) by mx.google.com with ESMTPSA id id1sm96532pbc.11.2014.01.19.22.22.02 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 19 Jan 2014 22:22:04 -0800 (PST) From: manjian2006@gmail.com To: gdb-patches@sourceware.org Cc: linzj Subject: [PATCH] fixed inherit_abstract_dies infinite recursive call Date: Mon, 20 Jan 2014 06:22:00 -0000 Message-Id: <1390198908-11691-1-git-send-email-manjian2006@gmail.com> X-SW-Source: 2014-01/txt/msg00734.txt.bz2 From: linzj The c++ code causing the problem is: // Integer variants of certain metrics, used for HTML rendering. int ascent(FontBaseline baselineType = AlphabeticBaseline) const { if (baselineType == AlphabeticBaseline) return lroundf(m_ascent); return height() - height() / 2; } int height(FontBaseline baselineType = AlphabeticBaseline) const { return ascent(baselineType) + descent(baselineType); } As you can see,ascent(0x5816d55) calls height(0x5812c1b),and height calls ascent(0x5816d55) recursivly.And the compiler generates these dwarf code representing this relationship preciously. A dwarf die may have the following relationship: 564860c<----------------------------- | | |(abstract origin) | | | V | 5816d55 | (abstract origin) | | |(child) | | | V | ... | 5812c34------------------------------ So inherit_abstract_dies may results in infinite recursive call. A bit field call in_process has been add to struct die_info to fix this problem. process_die would first check if a die is in processing state, if so,just return. Then in_process bit is set.Before process_die returns,this bit field is unset. --- gdb/dwarf2read.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 7ca527d..c226a52 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -1224,6 +1224,8 @@ struct die_info /* True if we're presently building the full type name for the type derived from this DIE. */ unsigned char building_fullname : 1; + /* True if this die is in process. */ + unsigned char in_process : 1; /* Abbrev number */ unsigned int abbrev; @@ -8013,6 +8015,10 @@ process_imported_unit_die (struct die_info *die, struct dwarf2_cu *cu) static void process_die (struct die_info *die, struct dwarf2_cu *cu) { + /* Only process those who are not in process. */ + if (die->in_process) + return; + die->in_process = 1; switch (die->tag) { case DW_TAG_padding: @@ -8100,6 +8106,7 @@ process_die (struct die_info *die, struct dwarf2_cu *cu) new_symbol (die, NULL, cu); break; } + die->in_process = 0; } /* DWARF name computation. */ -- 1.8.3.2