Re: [PATCH v10 00/28] record-btrace: reverse

Pedro Alves
2014-01-15T15:54:11Z

On 01/14/2014 08:04 AM, Markus Metzger wrote:
> This is a smaller update addressing Pedro's feedback.

Thank you.

>
> The "target: add ops parameter to to_prepare_to_store method" patch has
> been replaced with Tom's "Add target_ops argument to to_prepare_to_store"
> patch.
>
> In "record-btrace: provide xfer_partial target method" xfer_partial now
> returns an error code instead of throwing an error.
>
> The "frame: add frame_is_tailcall function" patch has been dropped since
> it is no longer needed. Btrace frames use NORMAL_FRAME and TAILCALL_FRAME
> instead of new BTRACE_ variants.
>
> An indentation error where the indentation in "record function-call-history"
> had been off by two spaces in some cases has been fixed.

I read through the series, and apart from the tiny nits in
two patches I sent out, I have no further comments. This looks
good to go to me. Congratulations! Quite a neat piece of work.

Thanks!
--
Pedro Alves