Re: [PATCH v1 1/3] Add AVX512 registers support to GDB.

Pedro Alves
2013-12-20T17:29:28Z

Hi there,

I skimmed this (not a real review), and noticed:

> +send_gdb "print have_avx512 ()\r"
> +gdb_expect {

Please use gdb_test_multiple instead of send_gdb/gdb_expect.

> + -re ".. = 1\r\n$gdb_prompt " {
> + pass "check whether processor supports AVX512"
> + }
> + -re ".. = 0\r\n$gdb_prompt " {

Should be a pass too:

pass "check whether processor supports AVX512"

As the test did its job.

> + }
> + -re ".*$gdb_prompt $" {
> + fail "check whether processor supports AVX512"
> + }
> + timeout {
> + fail "check whether processor supports AVX512 (timeout)"
> + }

These last two won't be necessary then.

> +}
> +

This:

> + verbose "processor does not support AVX512; skipping AVX512 tests"
> + return

should probably instead be:

unsupported "processor does not support AVX512; skipping AVX512 tests"

...

> +}
> \ No newline at end of file

Please add one.

--
Pedro Alves