Re: [PATCH v3 05/13] vla: update type from newly created value

Doug Evans
2013-12-06T07:36:19Z

Sanimir Agovic <sanimir.agovic@intel.com> writes:
> Constructing a value based on a type and address might change the type
> of the newly constructed value. Thus re-fetch type via value_type to ensure
> we have the correct type at hand.
>
> 2013-10-18 Sanimir Agovic <sanimir.agovic@intel.com>
> Keven Boell <keven.boell@intel.com>
>
> * ada-lang.c (ada_value_primitive_packed_val): Re-fetch type from value.
> (ada_template_to_fixed_record_type_1): Likewise.
> (ada_to_fixed_type_1): Likewise.
> * cp-valprint.c (cp_print_value_fields_rtti): Likewise.
> (cp_print_value): Likewise.
> * d-valprint.c (dynamic_array_type): Likewise.
> * jv-valprint.c (java_value_print): Likewise.
> * valops.c (value_ind): Likewise.
> * value.c (coerce_ref): Likewise.

Hi. Can you add a comment to each of the functions that
require this, saying something like "You must do <this> after calling me."
value_at, value_from_contents_and_address, others?

Apologies if I missed it. I think(!) I've read the entire v3 series.

Thanks.