Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Metzger <markus.t.metzger@intel.com>
To: jan.kratochvil@redhat.com
Cc: gdb-patches@sourceware.org
Subject: [patch v7 09/24] btrace: increase buffer size
Date: Fri, 29 Nov 2013 14:39:00 -0000	[thread overview]
Message-ID: <1385735899-12481-10-git-send-email-markus.t.metzger@intel.com> (raw)
In-Reply-To: <1385735899-12481-1-git-send-email-markus.t.metzger@intel.com>

Try to allocate as much buffer as we can for each thread with a maximum
of 64KB.

2013-11-29  Markus Metzger  <markus.t.metzger@intel.com>

	* common/linux-btrace.c (linux_enable_btrace): Enlarge buffer.


---
 gdb/common/linux-btrace.c | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/gdb/common/linux-btrace.c b/gdb/common/linux-btrace.c
index aa2b0ae..801505b 100644
--- a/gdb/common/linux-btrace.c
+++ b/gdb/common/linux-btrace.c
@@ -423,7 +423,7 @@ struct btrace_target_info *
 linux_enable_btrace (ptid_t ptid)
 {
   struct btrace_target_info *tinfo;
-  int pid;
+  int pid, pg;
 
   tinfo = xzalloc (sizeof (*tinfo));
   tinfo->ptid = ptid;
@@ -451,17 +451,22 @@ linux_enable_btrace (ptid_t ptid)
   if (tinfo->file < 0)
     goto err;
 
-  /* We hard-code the trace buffer size.
-     At some later time, we should make this configurable.  */
-  tinfo->size = 1;
-  tinfo->buffer = mmap (NULL, perf_event_mmap_size (tinfo),
-			PROT_READ, MAP_SHARED, tinfo->file, 0);
-  if (tinfo->buffer == MAP_FAILED)
-    goto err_file;
+  /* We try to allocate as much buffer as we can get.
+     We could allow the user to specify the size of the buffer, but then
+     we'd leave this search for the maximum buffer size to him.  */
+  for (pg = 4; pg >= 0; --pg)
+    {
+      /* The number of pages we request needs to be a power of two.  */
+      tinfo->size = 1 << pg;
+      tinfo->buffer = mmap (NULL, perf_event_mmap_size (tinfo),
+			    PROT_READ, MAP_SHARED, tinfo->file, 0);
+      if (tinfo->buffer == MAP_FAILED)
+	continue;
 
-  return tinfo;
+      return tinfo;
+    }
 
- err_file:
+  /* We were not able to allocate any buffer.  */
   close (tinfo->file);
 
  err:
-- 
1.8.3.1


  parent reply	other threads:[~2013-11-29 14:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29 14:38 [patch v7 00/24] record-btrace: reverse Markus Metzger
2013-11-29 14:38 ` [patch v7 04/24] frame: add frame_is_tailcall function Markus Metzger
2013-11-29 14:38 ` [patch v7 08/24] record-btrace: start counting at one Markus Metzger
2013-11-29 14:38 ` [patch v7 14/24] record-btrace: supply register target methods Markus Metzger
2013-11-29 14:38 ` [patch v7 01/24] btrace, linux: fix memory leak when reading branch trace Markus Metzger
2013-11-29 14:38 ` [patch v7 03/24] gdbarch: add instruction predicate methods Markus Metzger
2013-12-11 12:16   ` Pedro Alves
2013-11-29 14:39 ` [patch v7 13/24] target: add ops parameter to to_prepare_to_store method Markus Metzger
2013-11-29 14:39 ` [patch v7 19/24] record-btrace: provide target_find_new_threads method Markus Metzger
2013-11-29 14:39 ` [patch v7 23/24] record-btrace: show trace from enable location Markus Metzger
2013-11-29 14:39 ` [patch v7 05/24] frame: artificial frame id's Markus Metzger
2013-12-11 12:24   ` Pedro Alves
2013-12-11 19:58   ` Jan Kratochvil
2013-11-29 14:39 ` [patch v7 17/24] record-btrace: provide xfer_partial target method Markus Metzger
2013-11-29 14:39 ` [patch v7 16/24] record-btrace, frame: supply target-specific unwinder Markus Metzger
2013-11-29 14:39 ` [patch v7 12/24] btrace: add replay position to btrace thread info Markus Metzger
2013-11-29 14:39 ` [patch v7 11/24] record-btrace: make ranges include begin and end Markus Metzger
2013-11-29 14:39 ` [patch v7 07/24] record-btrace: fix insn range in function call history Markus Metzger
2013-11-29 14:39 ` Markus Metzger [this message]
2013-11-29 14:39 ` [patch v7 18/24] record-btrace: add to_wait and to_resume target methods Markus Metzger
2013-11-29 14:40 ` [patch v7 15/24] frame, backtrace: allow targets to supply a frame unwinder Markus Metzger
2013-11-29 14:40 ` [patch v7 21/24] record-btrace: extend unwinder Markus Metzger
2013-12-11 19:57   ` Jan Kratochvil
2013-11-29 14:40 ` [patch v7 06/24] btrace: change branch trace data structure Markus Metzger
2013-11-29 14:41 ` [patch v7 02/24] btrace: uppercase btrace_read_type Markus Metzger
2013-12-11 12:11   ` Pedro Alves
2013-11-29 14:41 ` [patch v7 20/24] record-btrace: add record goto target methods Markus Metzger
2013-11-29 14:42 ` [patch v7 10/24] record-btrace: optionally indent function call history Markus Metzger
2013-11-29 15:05 ` [patch v7 22/24] btrace, gdbserver: read branch trace incrementally Markus Metzger
2013-12-11 19:58   ` Jan Kratochvil
2013-12-12  8:24     ` Metzger, Markus T
2013-12-12  9:13       ` Jan Kratochvil
2013-11-29 15:11 ` [patch v7 24/24] record-btrace: add (reverse-)stepping support Markus Metzger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385735899-12481-10-git-send-email-markus.t.metzger@intel.com \
    --to=markus.t.metzger@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox