From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16017 invoked by alias); 27 Nov 2013 17:52:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15967 invoked by uid 89); 27 Nov 2013 17:52:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_20,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2013 17:52:51 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rARHqhOU021134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Nov 2013 12:52:43 -0500 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rARHqegr008883 for ; Wed, 27 Nov 2013 12:52:43 -0500 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 2/2] Make "set debug frame 1" output print instead of . Date: Wed, 27 Nov 2013 18:35:00 -0000 Message-Id: <1385574760-26557-3-git-send-email-palves@redhat.com> In-Reply-To: <1385574760-26557-1-git-send-email-palves@redhat.com> References: <5208D50F.8020109@broadcom.com> <1385574760-26557-1-git-send-email-palves@redhat.com> X-SW-Source: 2013-11/txt/msg00854.txt.bz2 "set debug frame 1" is printing "" for not saved registers. That's because the unwinders are returning optimized out not_lval values instead of optimized out lval_register values. "" is how val_print_optimized_out prints lval_register values. ... - { frame_unwind_register_value (frame=0,regnum=7(rsp),...) -> } + { frame_unwind_register_value (frame=0,regnum=7(rsp),...) -> } ... Tested on x86_64 Fedora 17. 2013-11-27 Pedro Alves * frame-unwind.c (frame_unwind_got_optimized): Return an lval_register value instead of a not_lval value. --- gdb/frame-unwind.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c index ce2f6da..68879f3 100644 --- a/gdb/frame-unwind.c +++ b/gdb/frame-unwind.c @@ -161,10 +161,12 @@ default_frame_unwind_stop_reason (struct frame_info *this_frame, struct value * frame_unwind_got_optimized (struct frame_info *frame, int regnum) { - struct gdbarch *gdbarch = frame_unwind_arch (frame); - struct type *reg_type = register_type (gdbarch, regnum); + struct value *val; - return allocate_optimized_out_value (reg_type); + val = value_of_register_lazy (frame, regnum); + set_value_lazy (val, 0); + set_value_optimized_out (val, 1); + return val; } /* Return a value which indicates that FRAME copied REGNUM into -- 1.7.11.7