From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4396 invoked by alias); 21 Nov 2013 01:18:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4290 invoked by uid 89); 21 Nov 2013 01:18:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_50,FROM_12LTRDOM,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Nov 2013 01:18:28 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VjIuI-00069P-0u from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Wed, 20 Nov 2013 17:18:10 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 20 Nov 2013 17:18:10 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Wed, 20 Nov 2013 17:18:09 -0800 From: Yao Qi To: Subject: [PATCH 0/3 V3] Cache code access for disassemble Date: Thu, 21 Nov 2013 01:34:00 -0000 Message-ID: <1384996594-20865-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00615.txt.bz2 Hi, This is the V3 of this patch series. Most of the patches were committed because they are cleanups, and V3 only has three patches. Patch 1/3 is to rename some functions and variables related to "stack-cache", to address review comments in V2 that we find they are improper. Patch 2/3 is to add commands "set/show code-cache", and we choose a way that "both stack cache and code cache use the single global dcache, and transitions of either options will invalidate the dcache". Patch 3/3 is unchanged. The performance improvement is measured by gdb.perf/disassemble.exp, posted https://sourceware.org/ml/gdb-patches/2013-11/msg00574.html (note that gdb.perf/disassemble.py is modified to flush code cache after each run) Original Patched disassemble cpu_time 0 0.49 0.16 disassemble cpu_time 1 0.93 0.21 disassemble cpu_time 2 1.35 0.33 disassemble wall_time 0 0.722337007523 0.167083024979 disassemble wall_time 1 1.37996888161 0.215560913086 disassemble wall_time 2 2.07086896896 0.323045969009 disassemble vmsize 0 151000 150880 disassemble vmsize 1 151692 151740 disassemble vmsize 2 151692 151740 Regression tested x86_64-linux. *** BLURB HERE *** Yao Qi (3): Renaming in target-dcache.c set/show code-cache Use target_read_code in disassemble. gdb/NEWS | 6 ++++ gdb/disasm.c | 2 +- gdb/doc/gdb.texinfo | 16 +++++++++- gdb/target-dcache.c | 81 +++++++++++++++++++++++++++++++++++++++++--------- gdb/target-dcache.h | 4 ++- gdb/target.c | 23 ++++++++++++-- gdb/target.h | 5 +++ 7 files changed, 115 insertions(+), 22 deletions(-) -- 1.7.7.6