From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2932 invoked by alias); 6 Nov 2013 17:25:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2905 invoked by uid 89); 6 Nov 2013 17:25:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Nov 2013 17:24:08 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA6HAHqn029463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Nov 2013 12:10:17 -0500 Received: from barimba.redhat.com (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA6HA2xx014519; Wed, 6 Nov 2013 12:10:17 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2 08/16] don't check for stddef.h Date: Wed, 06 Nov 2013 17:27:00 -0000 Message-Id: <1383757800-6332-9-git-send-email-tromey@redhat.com> In-Reply-To: <1383757800-6332-1-git-send-email-tromey@redhat.com> References: <1383757800-6332-1-git-send-email-tromey@redhat.com> X-SW-Source: 2013-11/txt/msg00131.txt.bz2 gdb already unconditionally includes stddef.h in many places. I think there is no reason to check for its existence. Also, Zack Weinberg's header file survey agrees: http://hacks.owlfolio.org/header-survey/ This patch removes the configure check and the inclusion guards. It also removes a redundant inclusion that I noticed in defs.h. 2013-11-06 Tom Tromey * config.in: Rebuild. * configure: Rebuild. * configure.ac: Don't check for stddef.h. * defs.h: Unconditionally include stddef.h. Remove duplicate inclusion. --- gdb/ChangeLog | 8 ++++++++ gdb/config.in | 3 --- gdb/configure | 2 +- gdb/configure.ac | 2 +- gdb/defs.h | 6 ------ 5 files changed, 10 insertions(+), 11 deletions(-) diff --git a/gdb/config.in b/gdb/config.in index 4e3f6de..802127f 100644 --- a/gdb/config.in +++ b/gdb/config.in @@ -378,9 +378,6 @@ /* Define to 1 if the system has the type `socklen_t'. */ #undef HAVE_SOCKLEN_T -/* Define to 1 if you have the header file. */ -#undef HAVE_STDDEF_H - /* Define to 1 if you have the header file. */ #undef HAVE_STDINT_H diff --git a/gdb/configure b/gdb/configure index e745fd1..844cfe0 100755 --- a/gdb/configure +++ b/gdb/configure @@ -8756,7 +8756,7 @@ fi # elf_hp.h is for HP/UX 64-bit shared library support. for ac_header in nlist.h machine/reg.h poll.h sys/poll.h proc_service.h \ - thread_db.h stddef.h \ + thread_db.h \ stdlib.h sys/fault.h \ sys/file.h sys/filio.h sys/ioctl.h sys/param.h \ sys/resource.h sys/procfs.h sys/ptrace.h ptrace.h \ diff --git a/gdb/configure.ac b/gdb/configure.ac index 51e734f..e48e4fd 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -1075,7 +1075,7 @@ fi AC_HEADER_STDC # elf_hp.h is for HP/UX 64-bit shared library support. AC_CHECK_HEADERS([nlist.h machine/reg.h poll.h sys/poll.h proc_service.h \ - thread_db.h stddef.h \ + thread_db.h \ stdlib.h sys/fault.h \ sys/file.h sys/filio.h sys/ioctl.h sys/param.h \ sys/resource.h sys/procfs.h sys/ptrace.h ptrace.h \ diff --git a/gdb/defs.h b/gdb/defs.h index b1caaad..bb93742 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -48,9 +48,7 @@ included, so it's ok to blank out gstdint.h. */ #define GCC_GENERATED_STDINT_H 1 -#ifdef HAVE_STDDEF_H #include -#endif #include @@ -606,10 +604,6 @@ enum gdb_osabi /* From other system libraries */ -#ifdef HAVE_STDDEF_H -#include -#endif - #ifdef HAVE_STDLIB_H #include #endif -- 1.8.1.4