Re: [PATCH 08/10] Don't invalidate dcache when option stack-cache is changed

Yao Qi
2013-11-19T13:12:16Z

On 11/19/2013 07:52 PM, Pedro Alves wrote:
> @@ -1593,14 +1593,14 @@ memory_xfer_partial_1 (struct target_ops *ops, enum target_object object,
>
> /* Make sure the cache gets updated no matter what - if we are writing
> to the stack. Even if this write is not tagged as such, we still need
> - to update the cache. */
> + to update the cache. Update the cache to keep it in sync if it
> + has been initialized. */
>
> if (res > 0
> && inf != NULL
> && writebuf != NULL
> && target_dcache_init_p ()
> && !region->attrib.cache
> - && stack_cache_enabled ()
> && object != TARGET_OBJECT_STACK_MEMORY)
> {
>
> ... we don't update the cache.

We do update the cache. When we do "set variable foo = 1" (foo is a
local variable), OBJECT is TARGET_OBJECT_MEMORY, so the condition above
is true and cache is updated then.

--
Yao (é½å°§)