From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5302 invoked by alias); 28 Oct 2013 12:50:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5285 invoked by uid 89); 28 Oct 2013 12:50:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2013 12:50:47 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VamHM-0005dc-Jy from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 28 Oct 2013 05:50:44 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 28 Oct 2013 05:50:44 -0700 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Mon, 28 Oct 2013 05:50:40 -0700 From: Yao Qi To: Subject: [PATCH 1/3] Constify 'la_name' in struct language_defn Date: Mon, 28 Oct 2013 12:50:00 -0000 Message-ID: <1382964489-24307-1-git-send-email-yao@codesourcery.com> In-Reply-To: <20131025041525.GC4769@adacore.com> References: <20131025041525.GC4769@adacore.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00854.txt.bz2 Hi, When I add another name of language, I find field 'la_name' can be 'const char *'. This patch is to constify it. gdb: 2013-10-28 Yao Qi * language.c (language_str): Return const char *. (add_language): Add const to 'language_names' * language.h (struct language_defn) : Add const. (language_str: Update declaration. --- gdb/language.c | 4 ++-- gdb/language.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/language.c b/gdb/language.c index dcad5f3..aa708b9 100644 --- a/gdb/language.c +++ b/gdb/language.c @@ -485,7 +485,7 @@ language_def (enum language lang) } /* Return the language as a string. */ -char * +const char * language_str (enum language lang) { int i; @@ -520,7 +520,7 @@ void add_language (const struct language_defn *lang) { /* For the "set language" command. */ - static char **language_names = NULL; + static const char **language_names = NULL; /* For the "help set language" command. */ char *language_set_doc = NULL; diff --git a/gdb/language.h b/gdb/language.h index 5e029ea..14aedb6 100644 --- a/gdb/language.h +++ b/gdb/language.h @@ -132,7 +132,7 @@ struct language_defn { /* Name of the language. */ - char *la_name; + const char *la_name; /* its symtab language-enum (defs.h). */ @@ -488,7 +488,7 @@ extern enum language language_enum (char *str); extern const struct language_defn *language_def (enum language); -extern char *language_str (enum language); +extern const char *language_str (enum language); /* Add a language to the set known by GDB (at initialization time). */ -- 1.7.7.6