From: Anton Kolesov <Anton.Kolesov@synopsys.com>
To: gdb-patches@sourceware.org
Cc: Jeremy Bennett <Jeremy.bennett@embecosm.com>
Subject: [PATCH v2] testsuite: Treat an empty string in needs_status_wrapper as false
Date: Mon, 21 Oct 2013 11:17:00 -0000 [thread overview]
Message-ID: <1382354229-10006-1-git-send-email-Anton.Kolesov@synopsys.com> (raw)
In-Reply-To: <39A54937CC95F24AA2F794E2D2B66B1356BD8887@de02wembxa.internal.synopsys.com>
GDB test suite considers [target_info needs_status_wrapper] to be false if
it unset or have a zero value. The former is achieved by using [target_info
exists needs_status_wrapper]. GCC test suite on the other hand do not use
"exists" but compares to an empty string. This doesn't make difference if
value is unset, as unset value is treated as an empty string, but makes a
difference if value was set to and empty string. In that case if
needs_status_wrapper was set to an empty string, then GCC test suite will
not use status wrapper, but GDB test suite will use it. Dejagnu's own
remote.exp uses a comparison with an empty string. Though for some reason
Dejagnu unlike GCC and GDB test suite doesn't treat a zero as a false.
This patch makes GDB test suite treat an empty string in
needs_status_wrapper the same way as it is done by GCC test suite and
Dejagnu.
gdb/testsuite/ChangeLog:
2013-10-21 Anton Kolesov <Anton.Kolesov@synopsys.com>
* lib/gdb.exp (gdb_compile, gdb_wrapper_init): Treat empty string in
target_info needs_status_wrapper the same way as zero - as a false value.
---
gdb/testsuite/lib/gdb.exp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 3efd539..1e5c34a 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2510,7 +2510,7 @@ proc gdb_wrapper_init { args } {
if { $gdb_wrapper_initialized == 1 } { return; }
- if {[target_info exists needs_status_wrapper] && \
+ if {[target_info needs_status_wrapper] != "" && \
[target_info needs_status_wrapper] != "0"} {
set result [build_wrapper "testglue.o"]
if { $result != "" } {
@@ -2609,7 +2609,7 @@ proc gdb_compile {source dest type options} {
if { $gdb_wrapper_initialized == 0 } { gdb_wrapper_init }
- if {[target_info exists needs_status_wrapper] && \
+ if {[target_info needs_status_wrapper] != "" && \
[target_info needs_status_wrapper] != "0" && \
[info exists gdb_wrapper_file]} {
lappend options "libs=${gdb_wrapper_file}"
--
1.8.4.1
next prev parent reply other threads:[~2013-10-21 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 12:59 [PATCH] testsuite: Treat empty string in needs_status_wrapper as a false value Anton Kolesov
2013-10-17 15:07 ` Anton Kolesov
2013-10-21 11:17 ` Anton Kolesov [this message]
2013-10-21 11:23 ` [PATCH v2] testsuite: Treat an empty string in needs_status_wrapper as false Pedro Alves
2013-10-22 10:51 ` [PATCH v3] " Anton Kolesov
2013-10-24 22:07 ` Pedro Alves
2013-10-25 9:25 ` Anton Kolesov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382354229-10006-1-git-send-email-Anton.Kolesov@synopsys.com \
--to=anton.kolesov@synopsys.com \
--cc=Jeremy.bennett@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox