Re: [PATCH 06/18] poison "delete"

Jan Kratochvil
2013-10-13T16:47:01Z

On Wed, 09 Oct 2013 19:17:21 +0200, Ondrej Oprala wrote:
[...]

Missing ChangeLog here.

> diff --git a/gdb/ui-file.h b/gdb/ui-file.h
> index ba0a908..8072fbd 100644
> --- a/gdb/ui-file.h
> +++ b/gdb/ui-file.h
> @@ -77,7 +77,7 @@ extern void set_ui_file_put (struct ui_file *stream, ui_file_put_ftype *put);
>
> typedef void (ui_file_delete_ftype) (struct ui_file * stream);
> extern void set_ui_file_data (struct ui_file *stream, void *data,
> - ui_file_delete_ftype *delete);
> + ui_file_delete_ftype *deleter);

The function definition already uses:

ui-file.c:
set_ui_file_data (struct ui_file *file, void *data,
ui_file_delete_ftype *delete_ptr)

Therefore I find better to get them in sync and use "delete_ptr" even in the
header file declaration.

>
> typedef int (ui_file_fseek_ftype) (struct ui_file *stream, long offset,
> int whence);
> --
> 1.8.3.1

Thanks,
Jan