Re: [PATCH 05/18] poison "private"

Jan Kratochvil
2013-10-13T16:45:16Z

On Wed, 09 Oct 2013 19:17:20 +0200, Ondrej Oprala wrote:
[...]
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -17,6 +17,17 @@
>
> 2013-10-09 Tom Tromey <tromey@redhat.com>
>
> + * gdbthread.h (private_data) : Renamed from private.

Use tab + parentheses always contain only the global object name, in this case
"struct thread_info". And s/ : /: /. Therefore:

* gdbthread.h (struct thread_info): Rename field private to
private_data.

One could also use:
* gdbthread.h (struct thread_info): Rename the field to private_data.

> + * inferior.c (private_data) : Likewise.
> + * inferior.h (private_data) : Likewise.
> + * jit.c (private_unwind) : Likewise.
> + * linux-thread-db.c (private_data, private_thr) : Likewise.
> + * nto-tdep.c (private_data) : Likewise.
> + * remote.c (private_data) : Likewise.
> + * thread.c (private_dtor, private_data) : Likewise.

Incorrect parentheses content like above.

> +
> +2013-10-09 Tom Tromey <tromey@redhat.com>
> +
> * gdbtypes.c (is_public): Renamed from public.
>
> 2013-10-09 Tom Tromey <tromey@redhat.com>
[...]

The patch itself is OK to commit.

Thanks,
Jan