Re: RFA [PATCH v4] Implement 'catch syscall' for gdbserver (was Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver)

Sergio Durigan Junior
2013-10-02T21:02:49Z

On Tuesday, October 01 2013, I wrote:

>> ChangeLog
>> 2013-xx-yy Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * NEWS: Document new QcatchSyscalls packet and its use
>> in x86/amd64 linux gdbserver and Valgrind gdbserver.
>> * remote.c (PACKET_QCatchSyscalls): New.
>> (remote_protocol_features): Add QcatchSyscalls.
>> (remote_set_syscall_catchpoint): New function.
>> (remote_parse_stop_reply): New stop reasons syscall_entry
>> and syscall_return.
>> (init_remote_ops): Registers remote_set_syscall_catchpoint
>> and the config commands for PACKET_QCatchSyscalls.
>> * common/linux-ptrace.c (linux_check_ptrace_features):
>> Detect PTRACE_O_TRACESYSGOOD for gdbserver.
>> (ptrace_supports_feature): Initializes ptrace features if needed.
>>
>> doc/ChangeLog
>> 2013-xx-yy Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * gdb.texinfo (General Query Packets): Document new QCatchSyscalls
>> packet.
>> (Stop Reply Packets): Document new stop reasons syscall_entry and
>> syscall_return.
>> (Async Records): Fixed syscall-return item name.
>>
>> gdbserver/ChangeLog
>> 2013-xx-yy Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * target.h (struct target_ops): Add supports_catch_syscall operation.
>> * linux-low.h (struct linux_target_ops): Add get_syscall_trapinfo
>> operation.
>> * linux-low.c (linux_wait_1): Enable, detect and handle
>> SYSCALL_SIGTRAP.
>> (gdb_catch_this_syscall_p): New function.
>> (get_syscall_trapinfo): New function.
>> (linux_supports_catch_syscall): New function.
>> (struct target_ops linux_target_ops): Set linux_supports_catch_syscall.
>> * linux-x86-low.c (x86_get_syscall_trapinfo): New function.
>> (struct linux_target_ops the_low_target): Set x86_get_syscall_trapinfo.
>> * remote-utils.c (prepare_resume_reply): Handle status kinds
>> TARGET_WAITKIND_SYSCALL_ENTRY and TARGET_WAITKIND_SYSCALL_RETURN.
>> * server.h: Declare catching_syscalls_p, syscalls_to_catch_size and
>> syscalls_to_catch.
>> * server.c: Define catching_syscalls_p, syscalls_to_catch_size and
>> syscalls_to_catch.
>> (handle_general_set): Handle QCatchSyscalls packet.
>> (handle_query): Reports if low target supports QCatchSyscalls.
>> * win32-low.c (struct target_ops win32_target_op): Sets NULL
>> for supports_catch_syscall.
>>
>> testsuite/ChangeLog
>> 2013-xx-yy Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * gdb.base/catch-syscall.exp: Enables test for x86 and amd64
>> gdbserver.
>>

BTW, I totally forgot about it, but you should take ownership of PR
remote/13585, mention it in the ChangeLog entries, and close it when the
patch is committed.

Thanks!

--
Sergio