From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 871 invoked by alias); 3 Sep 2013 20:26:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 825 invoked by uid 89); 3 Sep 2013 20:26:43 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Sep 2013 20:26:43 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r83KQfPr024444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 3 Sep 2013 16:26:41 -0400 Received: from brno.lan (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r83KQdrl028397 for ; Tue, 3 Sep 2013 16:26:40 -0400 From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 0/9][gdbserver] Split server.h. Date: Tue, 03 Sep 2013 20:26:00 -0000 Message-Id: <1378239999-15533-1-git-send-email-palves@redhat.com> X-SW-Source: 2013-09/txt/msg00104.txt.bz2 The recurring theme of doing: #ifdef GDBSERVER #include "server.h" #else #include "defs.h" #endif in common/ code is a bit annoying. I think we'll end up proving a defs.h in gdbserver, and we'll want to share as much with gdb's as possible. I considered just renaming server.h to defs.h, but looking at server.h, I think it's better to first split out things that don't really need to be there. Now that gdbserver's Makefile does automatic dependency tracking, it's easy enough to split the parts that actually define interfaces of specific modules to their own files. This series does that. Some of the new headers remain included in server.h (at least for now), for they define things that are truly used throughout the code, and I was hating the fact that I was ending up adding #include remote-utils.h throughout in a previous attempt, with "utils" being yet another kitchensink, which I prefer avoiding. Still, I think it still makes things clearer this way. I think we should do the same on the gdb side too. Tested on x86_64 Fedora 17. I'll apply it tomorrow, barring comments. Pedro Alves (9): [gdbserver] Delete _ macro (gettext). [gdbserver] Split a new remote-utils.h file out of server.h. [gdbserver] Split a new utils.h file out of server.h. [gdbserver] Split a new tracepoint.h file out of server.h. [gdbserver] Split a new ax.h file out of server.h. [gdbserver] Split a new inferiors.h file out of server.h. [gdbserver] Split a new dll.h file out of server.h. [gdbserver] Split a new event-loop.h file out of server.h. [gdbserver] Split a new hostio.h file out of server.h. gdb/gdbserver/ax.c | 1 + gdb/gdbserver/ax.h | 57 +++++++ gdb/gdbserver/dll.c | 1 + gdb/gdbserver/dll.h | 35 ++++ gdb/gdbserver/event-loop.h | 36 ++++ gdb/gdbserver/gdbthread.h | 1 + gdb/gdbserver/hostio.c | 1 + gdb/gdbserver/hostio.h | 28 +++ gdb/gdbserver/inferiors.c | 1 + gdb/gdbserver/inferiors.h | 114 +++++++++++++ gdb/gdbserver/linux-low.c | 2 + gdb/gdbserver/linux-x86-low.c | 2 + gdb/gdbserver/remote-utils.c | 2 + gdb/gdbserver/remote-utils.h | 85 ++++++++++ gdb/gdbserver/server.c | 3 + gdb/gdbserver/server.h | 385 +----------------------------------------- gdb/gdbserver/target.c | 1 + gdb/gdbserver/target.h | 1 + gdb/gdbserver/tracepoint.c | 1 + gdb/gdbserver/tracepoint.h | 132 +++++++++++++++ gdb/gdbserver/utils.h | 32 ++++ 21 files changed, 541 insertions(+), 380 deletions(-) create mode 100644 gdb/gdbserver/dll.h create mode 100644 gdb/gdbserver/event-loop.h create mode 100644 gdb/gdbserver/hostio.h create mode 100644 gdb/gdbserver/inferiors.h create mode 100644 gdb/gdbserver/remote-utils.h create mode 100644 gdb/gdbserver/tracepoint.h create mode 100644 gdb/gdbserver/utils.h -- 1.7.11.7