Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Walfred Tedeschi <walfred.tedeschi@intel.com>
To: gdb-patches@sourceware.org, walfred.tedeschi@intel.com,
	       mircea.gherzan@intel.com
Subject: [PATCH v3 6/8] Add pretty-printer for MPX bnd registers.
Date: Fri, 30 Aug 2013 09:58:00 -0000	[thread overview]
Message-ID: <1377856683-11267-7-git-send-email-walfred.tedeschi@intel.com> (raw)
In-Reply-To: <1377856683-11267-1-git-send-email-walfred.tedeschi@intel.com>

Boundary length is simpler implemented by means of a pretty
printer. This simplifies users life when examining a bound register.

Changelog:
2012-10-16 Walfred Tedeschi <walfred.tedeschi@intel.com>

gdb/python/lib/gdb/command

	* bound_register.py: New file.

gdb/data-directory
	* Makefile.in: copy bond_register.py to the right path to
	be initialized at gdb startup.

testsuite/gdb.python

	* py-pp-maint.exp: Consider new pretty-print added for registers.

Signed-off-by: Walfred Tedeschi <walfred.tedeschi@intel.com>
---
 gdb/data-directory/Makefile.in                |    1 +
 gdb/python/lib/gdb/command/bound_registers.py |   45 +++++++++++++++++++++++++
 gdb/testsuite/gdb.python/py-pp-maint.exp      |    8 ++---
 3 files changed, 50 insertions(+), 4 deletions(-)
 create mode 100644 gdb/python/lib/gdb/command/bound_registers.py

diff --git a/gdb/data-directory/Makefile.in b/gdb/data-directory/Makefile.in
index 3d05213..1e00c58 100644
--- a/gdb/data-directory/Makefile.in
+++ b/gdb/data-directory/Makefile.in
@@ -61,6 +61,7 @@ PYTHON_FILES = \
 	gdb/types.py \
 	gdb/printing.py \
 	gdb/prompt.py \
+	gdb/command/bound_registers.py \
 	gdb/command/__init__.py \
 	gdb/command/frame_filters.py \
 	gdb/command/type_printers.py \
diff --git a/gdb/python/lib/gdb/command/bound_registers.py b/gdb/python/lib/gdb/command/bound_registers.py
new file mode 100644
index 0000000..0b1baf6
--- /dev/null
+++ b/gdb/python/lib/gdb/command/bound_registers.py
@@ -0,0 +1,45 @@
+# Pretty-printer utilities.
+# Copyright (C) 2013 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import gdb.printing
+
+class BoundPrinter:
+    """Adds size field to a _rawbound128 type."""
+
+    def __init__ (self, val):
+        self.val = val
+
+    def to_string (self):
+        upper = self.val["ubound"]
+        lower = self.val["lbound"]
+        size  = (long) ((upper) - (lower))
+        if size > -1:
+            size = size + 1
+        result = '{lbound = %s, ubound = %s} : size %s' % (lower, upper, size)
+        return result
+
+# There are two pattern matching used: first one is related to a library
+# second is related to the type. Since we are displaying a register all
+# libraries are accepted. Type to be processed is the same present
+# in the xml file.
+
+def build_pretty_printer ():
+    pp = gdb.printing.RegexpCollectionPrettyPrinter (".*")
+    pp.add_printer ('bound', '^__gdb_builtin_type_bound128', BoundPrinter)
+    return pp
+
+gdb.printing.register_pretty_printer (gdb.current_objfile (),
+                                      build_pretty_printer ())
diff --git a/gdb/testsuite/gdb.python/py-pp-maint.exp b/gdb/testsuite/gdb.python/py-pp-maint.exp
index 4b5ef5a..023d55f 100644
--- a/gdb/testsuite/gdb.python/py-pp-maint.exp
+++ b/gdb/testsuite/gdb.python/py-pp-maint.exp
@@ -60,7 +60,7 @@ gdb_test "print flt" " = x=<42> y=<43>" \
 gdb_test "print ss" " = a=<a=<1> b=<$hex>> b=<a=<2> b=<$hex>>" \
     "print ss enabled #1"
 
-set num_pp 6
+set num_pp 7
 
 gdb_test "disable pretty-printer" \
     "$num_pp printers disabled.*0 of $num_pp printers enabled"
@@ -78,7 +78,7 @@ gdb_test "disable pretty-printer global lookup_function_lookup_test" \
     "1 printer disabled.*[expr $num_pp - 1] of $num_pp printers enabled"
 
 gdb_test "disable pretty-printer global pp-test;.*" \
-    "[expr $num_pp - 1] printers disabled.*0 of $num_pp printers enabled"
+    "[expr $num_pp - 2] printers disabled.*1 of $num_pp printers enabled"
 
 gdb_test "info pretty-printer global .*function" \
     {.*function_lookup_test \[disabled\].*}
@@ -93,13 +93,13 @@ gdb_test "print ss" " = {a = {a = 1, b = $hex}, b = {a = 2, b = $hex}}" \
     "print ss disabled"
 
 gdb_test "enable pretty-printer global lookup_function_lookup_test" \
-    "1 printer enabled.*1 of $num_pp printers enabled"
+    "1 printer enabled.*2 of $num_pp printers enabled"
 
 # This doesn't enable any printers because each subprinter in the collection
 # is still individually disabled.  But this is still needed, to enable the
 # collection itself.
 gdb_test "enable pretty-printer global pp-test" \
-    "0 printers enabled.*1 of $num_pp printers enabled"
+    "0 printers enabled.*2 of $num_pp printers enabled"
 
 gdb_test "enable pretty-printer global pp-test;.*ss.*" \
     "2 printers enabled.*[expr $num_pp - 3] of $num_pp printers enabled"
-- 
1.7.10.4


  parent reply	other threads:[~2013-08-30  9:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  9:58 [PATCH v3 0/8] Intel(R) MPX registers Walfred Tedeschi
2013-08-30  9:58 ` [PATCH v3 4/8] MPX for amd64 Walfred Tedeschi
2013-08-30  9:58 ` [PATCH v3 5/8] Add MPX support to gdbserver Walfred Tedeschi
2013-08-30  9:58 ` [PATCH v3 1/8] Fix conditions in creating a bitfield Walfred Tedeschi
2013-08-30  9:58 ` [PATCH v3 8/8] Add MPX feature description to GDB manual Walfred Tedeschi
2013-08-30 12:06   ` Eli Zaretskii
2013-08-30  9:58 ` [PATCH v3 3/8] Add MPX support for i386 Walfred Tedeschi
2013-08-30  9:58 ` [PATCH v3 7/8] Add MPX registers tests Walfred Tedeschi
2013-08-30  9:58 ` [PATCH v3 2/8] Add MPX registers XML files Walfred Tedeschi
2013-08-30  9:58 ` Walfred Tedeschi [this message]
2013-08-30 12:07 ` [PATCH v3 0/8] Intel(R) MPX registers Eli Zaretskii
2013-09-02 12:18   ` Tedeschi, Walfred

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377856683-11267-7-git-send-email-walfred.tedeschi@intel.com \
    --to=walfred.tedeschi@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mircea.gherzan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox