Re: [PATCH 1/2] Use mi_getopt_silent

Pedro Alves
2013-08-27T11:43:18Z

On 08/27/2013 04:28 AM, Yao Qi wrote:
> On 08/27/2013 12:22 AM, Pedro Alves wrote:
>>>> -int
>>>> -mi_getopt (const char *prefix,
>>>> - int argc, char **argv,
>>>> - const struct mi_opt *opts,
>>>> - int *oind, char **oarg)
>>>> +/* See comments about mi_getopt and mi_getopt_silent in mi-getopt.h.
>>>> + When there is an unknown option, if ERROR_ON_UNKNOWN is true, it
>>>> + throws an error, otherwise return -1. */
>> ("throws" -> "returns"). I'd suggest:
>>
>
> I assume you meant "return" -> "returns" here.

Yeah, specifically, I meant, you have "it throws", so it should be
"it returns", as the subject is still "it".

> I also rename mi_getopt_silent to mi_getopt_allow_unknown.

Excellent! I like that.

--
Pedro Alves