Re: [PATCH 2/2] Add options to skip unavailable locals

Pedro Alves
2013-08-26T16:40:19Z

Looks good to me. A few tiny-tiny suggestions below:

> * NEWS: Mention the new option "--skip-unavailable" to MI
> commands '-stack-list-locals' '-stack-list-arguments' and
^
Missing comma.

> '-stack-list-variables'.

> Errors are printed as if they would be the parameter value. Use
> - zeroed ARG iff it should not be printed according to VALUES. */
> + zeroed ARG iff it should not be printed according to VALUES. If
> + SKIP_UNAVAILABLE is true, print ARG if it is available. */

"is true, only print ARG"

>
> static void
> list_arg_or_local (const struct frame_arg *arg, enum what_to_list what,
> - enum print_values values)
> + enum print_values values, int skip_unavailable)
> {

> /* Print a list of the objects for the frame FI in a certain form,
> which is determined by VALUES. The objects can be locals,
> - arguments or both, which is determined by WHAT. */
> + arguments or both, which is determined by WHAT. If SKIP_UNAVAILABLE
> + is true, print the arguments or local variables whose values are
> + available. */

"is true, only print the"

>
> static void
> list_args_or_locals (enum what_to_list what, enum print_values values,
> - struct frame_info *fi)
> + struct frame_info *fi, int skip_unavailable)
> {
> struct block *block;

--
Pedro Alves