From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111734 invoked by alias); 11 Sep 2018 09:51:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111725 invoked by uid 89); 11 Sep 2018 09:51:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1074, quicker X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Sep 2018 09:51:25 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7218A8190285; Tue, 11 Sep 2018 09:51:24 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2E02B27AC; Tue, 11 Sep 2018 09:51:20 +0000 (UTC) Subject: Re: [Buildroot] [PATCH 2/2] package/gdb: use stat() privided by the system To: Sergio Durigan Junior , Rich Felker References: <20180909163750.14196-1-romain.naour@gmail.com> <20180909163750.14196-2-romain.naour@gmail.com> <20180910174900.0b9f4133@windsurf> <20180910224128.GT1878@brightrain.aerifal.cx> <87lg88oolv.fsf@redhat.com> Cc: Romain Naour , Thomas Petazzoni , Romain Naour , buildroot@buildroot.org, gdb-patches@sourceware.org From: Pedro Alves Message-ID: <13772de6-1197-4182-e13f-3b4f27dfa22d@redhat.com> Date: Tue, 11 Sep 2018 09:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87lg88oolv.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00314.txt.bz2 On 09/11/2018 01:38 AM, Sergio Durigan Junior wrote: > This is happening because, before the commit mentioned above, > 'common-utils.c' (which gets transformed into 'common-utils-ipa.c' > during the gdbserver build) wasn't calling 'stat'. It doesn't seem like > a regression; it seems like a hidden problem that was uncovered by the > need of 'stat'. > > I don't know why this problem is manifesting only when compiling IPA, > and not when compiling 'common-utils.c' during GDB's/gdbserver's build. Because the IPA doesn't link with gnulib. And the answer to that wouldn't be as simple as "just link it in", because the IPA objects are supposed to be compiled with -fPIC and -fvisibility=hidden. So we'd need a third build of gnulib for the IPA. It doesn't seem like this code that calls stat (is_regular_file?) is useful for the IPA, so a quicker/simpler fix would be to simply move that function out of common-utils.c into some other file that is not shared with the IPA. Thanks, Pedro Alves