From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8568 invoked by alias); 23 Aug 2013 20:36:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8531 invoked by uid 89); 23 Aug 2013 20:36:57 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 23 Aug 2013 20:36:56 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7NKat80014100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 23 Aug 2013 16:36:55 -0400 Received: from barimba.redhat.com (ovpn-113-142.phx2.redhat.com [10.3.113.142]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7NKarxP017513; Fri, 23 Aug 2013 16:36:54 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 02/13] fix some simple thinkos in the test suite Date: Fri, 23 Aug 2013 20:37:00 -0000 Message-Id: <1377290210-483-3-git-send-email-tromey@redhat.com> In-Reply-To: <1377290210-483-1-git-send-email-tromey@redhat.com> References: <1377290210-483-1-git-send-email-tromey@redhat.com> X-SW-Source: 2013-08/txt/msg00701.txt.bz2 This fixes some parallelization thinkos from a while ago. I'm not sure how the problems ever slipped through. In addition to a thinko fix in twice.exp, this also finishes fixing it up for parallelization. * gdb.base/gcore-buffer-overflow.exp: Use standard_output_file, not standard_testfile. * gdb.base/twice.exp: Use standard_testfile, not standard_output_file. Use gdb_remote_download. --- gdb/testsuite/gdb.base/gcore-buffer-overflow.exp | 3 ++- gdb/testsuite/gdb.base/twice.exp | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp index 8d0867e..47dccf9 100644 --- a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp +++ b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp @@ -51,4 +51,5 @@ if { ! [ runto_main ] } then { return -1 } -gdb_gcore_cmd [standard_testfile gcore-buffer-overflow.test] "save a corefile" +gdb_gcore_cmd [standard_output_file gcore-buffer-overflow.test] \ + "save a corefile" diff --git a/gdb/testsuite/gdb.base/twice.exp b/gdb/testsuite/gdb.base/twice.exp index 936ddcb..9e7e334 100644 --- a/gdb/testsuite/gdb.base/twice.exp +++ b/gdb/testsuite/gdb.base/twice.exp @@ -14,7 +14,7 @@ # along with this program. If not, see . -standard_output_file twice.c +standard_testfile twice.c set options debug lappend options "additional_flags=-I." @@ -23,7 +23,7 @@ set fileid [open $local_srcfile w] puts $fileid "#include \"twice.c\"" close $fileid -remote_download host ${srcdir}/${subdir}/twice.c twice.c +gdb_remote_download host ${srcdir}/${subdir}/twice.c if { [gdb_compile $local_srcfile "${binfile}" executable $options] != "" } { untested twice.exp -- 1.8.1.4