RE: [PATCH 1/2] cleanup: rename is_ref_attr to attr_form_is_ref

Agovic, Sanimir
2013-07-23T14:10:35Z

2013-07-24 Sanimir Agovic <sanimir.agovic@intel.com>

* dwarf2read.c (attr_is_ref): Rename to attr_form_is_ref.
All uses updated.
(attr_form_is_ref): Move below attr_form_is_constant.

OK?

-Sanimir

> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Tuesday, July 23, 2013 03:55 PM
> To: Agovic, Sanimir
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH 1/2] cleanup: rename is_ref_attr to attr_form_is_ref
>
> >>>>> "Sanimir" == Sanimir Agovic <sanimir.agovic@intel.com> writes:
>
> Sanimir> 2013-07-24 Sanimir Agovic <sanimir.agovi@intel.com>
>
> Sanimir> * dwarf2read.c (attr_is_ref): Rename to attr_form_is_ref.
> Sanimir> All uses updated.
>
> The patch is ok.
> I think the ChangeLog should mention that the function moved.
>
> thanks,
> Tom
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052