[PATCH 2/2] cleanup: constify argument passed to dwarf form predicates

Sanimir Agovic
2013-07-23T11:03:51Z

Dwarf form predicate functions do not modify their argument and thus made
them const.

gdb:

2013-07-23 Sanimir Agovic <sanimir.agovic@inte.com>

dwarf2read.c (attr_form_is_block): Make argument const.
(attr_form_is_section_offset): Make argument const.
(attr_form_is_constant): Make argument const.
(attr_form_is_ref): Make argument const.

Change-Id: Ide9aae7260e904b76470b48973037d43e23c180a
---
gdb/dwarf2read.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 1ee36bb..6fe1686 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -1649,13 +1649,13 @@ static struct die_info *dwarf_alloc_die (struct dwarf2_cu *, int);
static void dwarf_decode_macros (struct dwarf2_cu *, unsigned int,
const char *, int);

-static int attr_form_is_block (struct attribute *);
+static int attr_form_is_block (const struct attribute *);

-static int attr_form_is_section_offset (struct attribute *);
+static int attr_form_is_section_offset (const struct attribute *);

-static int attr_form_is_constant (struct attribute *);
+static int attr_form_is_constant (const struct attribute *);

-static int attr_form_is_ref (struct attribute *);
+static int attr_form_is_ref (const struct attribute *);

static void fill_in_loclist_baton (struct dwarf2_cu *cu,
struct dwarf2_loclist_baton *baton,
@@ -19795,7 +19795,7 @@ dwarf_decode_macros (struct dwarf2_cu *cu, unsigned int offset,
if so return true else false. */

static int
-attr_form_is_block (struct attribute *attr)
+attr_form_is_block (const struct attribute *attr)
{
return (attr == NULL ? 0 :
attr->form == DW_FORM_block1
@@ -19815,7 +19815,7 @@ attr_form_is_block (struct attribute *attr)
of them. */

static int
-attr_form_is_section_offset (struct attribute *attr)
+attr_form_is_section_offset (const struct attribute *attr)
{
return (attr->form == DW_FORM_data4
|| attr->form == DW_FORM_data8
@@ -19836,7 +19836,7 @@ attr_form_is_section_offset (struct attribute *attr)
taken as section offsets, not constants. */

static int
-attr_form_is_constant (struct attribute *attr)
+attr_form_is_constant (const struct attribute *attr)
{
switch (attr->form)
{
@@ -19857,7 +19857,7 @@ attr_form_is_constant (struct attribute *attr)
besides DW_FORM_ref_addr it is stored as cu_offset in the DWARF file. */

static int
-attr_form_is_ref (struct attribute *attr)
+attr_form_is_ref (const struct attribute *attr)
{
switch (attr->form)
{
--
1.7.1.1