From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 649 invoked by alias); 29 Jun 2013 03:11:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 510 invoked by uid 89); 29 Jun 2013 03:11:01 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 29 Jun 2013 03:10:59 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UslYw-0006cR-5E from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Fri, 28 Jun 2013 20:10:58 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 28 Jun 2013 20:10:58 -0700 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Fri, 28 Jun 2013 20:10:57 -0700 From: Yao Qi To: Subject: [PATCH 1/5] Share 'enum target_hw_bp_type' in GDB and GDBserver. Date: Sat, 29 Jun 2013 03:11:00 -0000 Message-ID: <1372475427-24862-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1372475427-24862-1-git-send-email-yao@codesourcery.com> References: <1369881867-11372-1-git-send-email-yao@codesourcery.com> <1372475427-24862-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-06/txt/msg00927.txt.bz2 Hi, 'enum target_hw_bp_type' has been used in both GDB and GDBserver. It will be used in MIPS hardware watchpoint support too. This patch is to share 'enum target_hw_bp_type' in common/break-common.h. gdb: 2013-06-29 Yao Qi * breakpoint.h: Include break-common.h. (enum target_hw_bp_type): Move to ... * common/break-common.h: ... here. New. gdb/gdbserver: 2013-06-29 Yao Qi * i386-low.c: Include break-common.h. (enum target_hw_bp_type): Remove. --- gdb/breakpoint.h | 10 +--------- gdb/common/break-common.h | 30 ++++++++++++++++++++++++++++++ gdb/gdbserver/i386-low.c | 9 +-------- 3 files changed, 32 insertions(+), 17 deletions(-) create mode 100644 gdb/common/break-common.h diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h index 19961fe..c82bc71 100644 --- a/gdb/breakpoint.h +++ b/gdb/breakpoint.h @@ -24,6 +24,7 @@ #include "vec.h" #include "ax.h" #include "command.h" +#include "break-common.h" struct value; struct block; @@ -215,15 +216,6 @@ enum bpdisp disp_donttouch /* Leave it alone */ }; -enum target_hw_bp_type - { - hw_write = 0, /* Common HW watchpoint */ - hw_read = 1, /* Read HW watchpoint */ - hw_access = 2, /* Access HW watchpoint */ - hw_execute = 3 /* Execute HW breakpoint */ - }; - - /* Status of breakpoint conditions used when synchronizing conditions with the target. */ diff --git a/gdb/common/break-common.h b/gdb/common/break-common.h new file mode 100644 index 0000000..16ed0e2 --- /dev/null +++ b/gdb/common/break-common.h @@ -0,0 +1,30 @@ +/* Data structures associated with breakpoints shared in both GDB and + GDBserver. + Copyright (C) 1992-2013 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ +#ifndef BREAK_COMMON_H +#define BREAK_COMMON_H 1 + +enum target_hw_bp_type + { + hw_write = 0, /* Common HW watchpoint */ + hw_read = 1, /* Read HW watchpoint */ + hw_access = 2, /* Access HW watchpoint */ + hw_execute = 3 /* Execute HW breakpoint */ + }; + +#endif diff --git a/gdb/gdbserver/i386-low.c b/gdb/gdbserver/i386-low.c index 86ec5d8..4eacda0 100644 --- a/gdb/gdbserver/i386-low.c +++ b/gdb/gdbserver/i386-low.c @@ -20,6 +20,7 @@ #include "server.h" #include "target.h" #include "i386-low.h" +#include "break-common.h" /* Support for 8-byte wide hw watchpoints. */ #ifndef TARGET_HAS_DR_LEN_8 @@ -27,14 +28,6 @@ #define TARGET_HAS_DR_LEN_8 (sizeof (void *) == 8) #endif -enum target_hw_bp_type - { - hw_write = 0, /* Common HW watchpoint */ - hw_read = 1, /* Read HW watchpoint */ - hw_access = 2, /* Access HW watchpoint */ - hw_execute = 3 /* Execute HW breakpoint */ - }; - /* DR7 Debug Control register fields. */ /* How many bits to skip in DR7 to get to R/W and LEN fields. */ -- 1.7.7.6