From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10455 invoked by alias); 18 Jun 2013 19:44:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10425 invoked by uid 89); 18 Jun 2013 19:44:35 -0000 X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 18 Jun 2013 19:44:34 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5IJiXwX006932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 18 Jun 2013 15:44:33 -0400 Received: from barimba.redhat.com (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5IJiWlk021231; Tue, 18 Jun 2013 15:44:33 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 1/3] fix dwarf_decode_line_header Date: Tue, 18 Jun 2013 19:44:00 -0000 Message-Id: <1371584669-1687-2-git-send-email-tromey@redhat.com> In-Reply-To: <1371584669-1687-1-git-send-email-tromey@redhat.com> References: <1371584669-1687-1-git-send-email-tromey@redhat.com> X-SW-Source: 2013-06/txt/msg00459.txt.bz2 dwarf_decode_line_header has one return that is missing a call to do_cleanups. This patch adds it. This was found using the cleanup checker. * dwarf2read.c (dwarf_decode_line_header): Call do_cleanups on all return paths. --- gdb/dwarf2read.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 4cd0c0e..bbb8584 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -15655,6 +15655,7 @@ dwarf_decode_line_header (unsigned int offset, struct dwarf2_cu *cu) if (line_ptr + lh->total_length > (section->buffer + section->size)) { dwarf2_statement_list_fits_in_line_number_section_complaint (); + do_cleanups (back_to); return 0; } lh->statement_program_end = line_ptr + lh->total_length; -- 1.8.1.4