Re: [PATCH 5/6] New MI command -trace-frame-collected

Eli Zaretskii
2013-06-13T13:09:02Z

> From: Yao Qi <yao@codesourcery.com>
> Date: Thu, 13 Jun 2013 09:28:33 +0800
>
> This patch adds the new MI command -trace-frame-collected, which can
> dump explicitly collected variables, computed expressions, tvars,
> memory and registers. See details in the doc about MI command
> options.

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 2c66db7..d480f45 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -80,6 +80,10 @@ show range-stepping
> "--skip-unavailable" option. When used, only the available registers
> are displayed.
>
> + ** The new command -trace-frame-collected dumps explicitly collected
> + variables, computed expressions, tvars, memory and registers in a
> + traceframe.
> +

This is OK.

> +This command returns the set of explicitly wholly collected objects,

What is meant by "explicitly wholly collected objects"? That phrase
got me confused, especially the "wholly" part.

> +For instance, if the actions were @code{myVar, myArray[myIndex]
> +myObj.field, myPtr->field, myCount + 2, *(int*)0xaf02bef0@@40}, the

It is better to put the code part in @smallexample.

> +@item computed-expressions
> +The set of computed expressions that have been collected at the
> +current trace frame. The @code{--comp-print-values} option affects
> +this set, as the @code{--var-print-values} option affects the
^^
"like", not "as". And you don't need the comma before that.

OK with the above changes, and assuming we resolve the "wholly" issue.