Re: [PATCH 4/6] Add id of TSV into traceframe_info.

Eli Zaretskii
2013-06-13T02:46:59Z

> From: Yao Qi <yao@codesourcery.com>
> Date: Thu, 13 Jun 2013 09:28:32 +0800
>
> Hi,
> This patch extends the qXfer:traceframe-info object to report the set
> of collected trace state variables in the current traceframe.
>
> Since VEC(int) is used in tracepoint.h, to avoid duplicated definition
> error, this patch also moves DEF_VEC_I(int) to gdb_vecs.h, and include
> it in other files instead of defining it by their own.
>
> When GDB reads from trace file (tfile or ctf), the traceframe_ifo
> object should be updated for trace state variables as well.
>
> gdb:
>
> 2013-06-13 Pedro Alves <pedro@codesourcery.com>
> Yao Qi <yao@codesourcery.com>
>
> * ctf.c (ctf_traceframe_info): Push trace state variables
> present in the trace data into the traceframe info object.
> * breakpoint.c (DEF_VEC_I): Remove.
> * common/filestuff.c (DEF_VEC_I): Likewise.
> * dwarf2loc.c (DEF_VEC_I): Likewise.
> * mi/mi-main.c (DEF_VEC_I): Likewise.
> * common/gdb_vecs.h (DEF_VEC_I): Define vector for int.
> * features/traceframe-info.dtd: Add tvar element and its
> attributes.
> * tracepoint.c (free_traceframe_info): Free vector 'tvars'.
> (build_traceframe_info): Push trace state variables present in the
> trace data into the traceframe info object.
> (traceframe_info_start_tvar): New function.
> (tvar_attributes): New.
> (traceframe_info_children): Add "tvar" element.
> * tracepoint.h (struct traceframe_info) <tvars>: New field.
>
> * NEWS: Mention the change in GDB and GDBserver.
>
> gdb/doc:
>
> 2013-06-13 Pedro Alves <pedro@codesourcery.com>
>
> * gdb.texinfo (Traceframe Info Format): Document tvar element and
> its attributes.
>
> gdb/gdbserver:
>
> 2013-06-13 Pedro Alves <pedro@codesourcery.com>
>
> * tracepoint.c (build_traceframe_info_xml): Output trace state
> variables present in the trace buffer.

The documentation parts are OK. Thanks.