From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +ChdNiMp42DSYgAAWB0awg (envelope-from ) for ; Mon, 05 Jul 2021 11:45:39 -0400 Received: by simark.ca (Postfix, from userid 112) id DC47A1F1F2; Mon, 5 Jul 2021 11:45:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=MAILING_LIST_MULTI, RDNS_DYNAMIC autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 984AB1E940 for ; Mon, 5 Jul 2021 11:45:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 619F43864811 for ; Mon, 5 Jul 2021 15:45:39 +0000 (GMT) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by sourceware.org (Postfix) with ESMTPS id 956A0385781D for ; Mon, 5 Jul 2021 15:45:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 956A0385781D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f49.google.com with SMTP id t6so12676852wrm.9 for ; Mon, 05 Jul 2021 08:45:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FRO5fEyyjLRTB+RP42T6ggC+kK6e4th3enGcBtmNQD8=; b=Op35VItMpDioXgaQgJkodZsi631slj8r2Usrv8Ck8RHRl01cEVkOQXekWwzOa85hIf mjuN/6ZZsdchzeSmUPxxq1uDJUvfKmYQEw6txUULy962SaTc0RXDw63e+RdJOQiIx465 lqFmNiTP6Qeyc0wdVA/Hhdwi0VepzvHg98W4sY5EfdzQTBjmID3F3J4NejtrgtIeoKL9 ZJ8ZwVEHzMZksyKAoCaoOsfp2mLTsrGQ8mYM8JTL4s8vboRmujoVt66B5JdjW6/mOgRg MqzMKVpuB6Yz4C749K66/V+4qJZaqMPbILiwoWrLQ4AztA8u1Ka+jpu+b0+bPEoQqerY 9qHA== X-Gm-Message-State: AOAM5335A1A+bUo9vyRS8K9UkkAUQXXQTWHt+0ecKVt80ZQt2Ew0xRFY Ix3tEBNSRKPFiO9v5jTZbVkjUGGW5hNe4A== X-Google-Smtp-Source: ABdhPJy1LhwBILkj5SsSTfvGpRRe5XuUVcttWqQntmYvolz5g2P5A+sjKgvMu+v66A1zgbufnwYaHg== X-Received: by 2002:a5d:548a:: with SMTP id h10mr16198783wrv.273.1625499912153; Mon, 05 Jul 2021 08:45:12 -0700 (PDT) Received: from ?IPv6:2001:8a0:f932:6a00:46bc:d03b:7b3a:2227? ([2001:8a0:f932:6a00:46bc:d03b:7b3a:2227]) by smtp.gmail.com with ESMTPSA id f18sm14041039wru.53.2021.07.05.08.45.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jul 2021 08:45:11 -0700 (PDT) Subject: Re: [PATCH 04/11] gdb: use intrusive list for step-over chain From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210622165704.2404007-1-simon.marchi@polymtl.ca> <20210622165704.2404007-5-simon.marchi@polymtl.ca> Message-ID: <136e1ed0-5a65-dd7f-cc58-34f64cc5895f@palves.net> Date: Mon, 5 Jul 2021 16:45:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210622165704.2404007-5-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-06-22 5:56 p.m., Simon Marchi via Gdb-patches wrote: > * reference-to-pointer-iterator.h (struct > reference_to_pointer_iterator): Add default assignment > operators. It's not immediately obvious why this is needed now, and wasn't before. It should perhaps be mentioned in the commit log. Especially if you decide to discard the ChangeLog entry. Otherwise LGTM.