Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/

Yao Qi
2013-06-20T13:39:17Z

Maciej,
Thanks for the review. I'll split this patch. A question to the
comment below,

On 06/20/2013 06:03 AM, Maciej W. Rozycki wrote:
>> +uint32_t mips_linux_watch_get_num_valid (struct pt_watch_regs *regs);
>> >+uint32_t mips_linux_watch_get_irw_mask (struct pt_watch_regs *regs,
>> >+ int set);
>> >+CORE_ADDR mips_linux_watch_get_watchlo (struct pt_watch_regs *regs,
>> >+ int set);
> The two prototypes above will fit in a single line each.
>

If we put the prototypes into a single line, the length exceeds the
74-character limit. This is the reason I moved parameter "set" to a new
line. Shall we keep them as what they are now?

>
>> >+int mips_linux_watch_try_one_watch (struct pt_watch_regs *regs,
>> >+ CORE_ADDR addr, int len,
>> >+ unsigned irw);
> The three last arguments above will fit in a single line.

Likewise.

--
Yao (é½å°§)