Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/

Maciej W. Rozycki
2013-06-20T15:26:14Z

On Thu, 20 Jun 2013, Yao Qi wrote:

> > > +uint32_t mips_linux_watch_get_num_valid (struct pt_watch_regs *regs);
> > > >+uint32_t mips_linux_watch_get_irw_mask (struct pt_watch_regs *regs,
> > > >+ int set);
> > > >+CORE_ADDR mips_linux_watch_get_watchlo (struct pt_watch_regs *regs,
> > > >+ int set);
> > The two prototypes above will fit in a single line each.
> >
>
> If we put the prototypes into a single line, the length exceeds the
> 74-character limit. This is the reason I moved parameter "set" to a new line.
> Shall we keep them as what they are now?

There's no 74-character limit for code, all you need is to stay within 79
columns. Did you apply the ChangeLog rule here?

Maciej