From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28686 invoked by alias); 30 May 2013 02:44:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28661 invoked by uid 89); 30 May 2013 02:44:00 -0000 X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=no version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 30 May 2013 02:43:59 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UhsqL-0006Y2-Fh from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Wed, 29 May 2013 19:43:57 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 29 May 2013 19:43:57 -0700 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Wed, 29 May 2013 19:43:56 -0700 From: Yao Qi To: Subject: [PATCH 0/3] mips hardware watchpoint support in gdbserver Date: Thu, 30 May 2013 02:44:00 -0000 Message-ID: <1369881867-11372-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg01039.txt.bz2 Hi, This patch series is to post Jie and Dan's work to support mips hardware watchpoint in gdbserver. The patch exists in the codesourcery tree for a while, when I rebase the patch for on top of FSF GDB trunk, I find that kernel header structs are defined in gdb while they are not defined in gdbserver because it includes asm/ptrace.h. After some thought, it should be safe to include asm/ptrace.h in gdb to get rid of these local structs, so this is what patch 1/3 does. It is a cleanup one. See more explanations in the patch itself. Then, I find there are some duplications between gdb and gdbserver on manipulating h/w watchpoints, so I merge the common part to common/mips-linux-watch.[h,c]. gdb and gdbserver supports h/w watchpoints for some targets, such as i386 and arm, but no one shares common code in common/ directory before. Ulrich Weigand expressed the intention for sharing for arm h/w watchpoint support in gdbserver I am not sure upstream maintainers' opinion on this. That is what patch 2/3 does. Finally, patch 3/3 is about the rest of gdbserver stuff for h/w watchpoint. The patch series are tested on some mips boards with gdbserver, with a hack that force proc skip_hw_watchpoint_tests return false. Many fails are fixed and no regressions (note that there is a regression in gdb.base/watchpoint.exp, but it is caused by a previous internal error). I also mange to run testsuite native mips gdb on a mips board, watchpoint related tests seem OK. The whole testsuite is not run because of the very slow speed. Is It OK? *** BLURB HERE *** Yao Qi (3): Include asm/ptrace.h in mips-linux-nat.c Move mips hardware watchpoint stuff to common/ MIPS GDBserver watchpoint gdb/Makefile.in | 6 +- gdb/common/mips-linux-watch.c | 358 +++++++++++++++++++++++++++++++++ gdb/common/mips-linux-watch.h | 76 +++++++ gdb/config/mips/linux.mh | 2 +- gdb/gdbserver/Makefile.in | 5 +- gdb/gdbserver/configure.srv | 2 +- gdb/gdbserver/linux-mips-low.c | 330 ++++++++++++++++++++++++++++++ gdb/mips-linux-nat.c | 431 +++------------------------------------ 8 files changed, 809 insertions(+), 401 deletions(-) create mode 100644 gdb/common/mips-linux-watch.c create mode 100644 gdb/common/mips-linux-watch.h -- 1.7.7.6