From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28741 invoked by alias); 27 May 2013 15:59:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28726 invoked by uid 89); 27 May 2013 15:59:38 -0000 X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS,TW_XS autolearn=ham version=3.3.1 Received: from mail-bk0-f54.google.com (HELO mail-bk0-f54.google.com) (209.85.214.54) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 27 May 2013 15:59:37 +0000 Received: by mail-bk0-f54.google.com with SMTP id it16so3410944bkc.27 for ; Mon, 27 May 2013 08:59:35 -0700 (PDT) X-Received: by 10.204.239.199 with SMTP id kx7mr3112218bkb.153.1369670375545; Mon, 27 May 2013 08:59:35 -0700 (PDT) Received: from [130.237.20.66] (s1499.it.kth.se. [130.237.20.66]) by mx.google.com with ESMTPSA id i15sm8643005bkz.12.2013.05.27.08.59.34 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 27 May 2013 08:59:34 -0700 (PDT) Message-ID: <1369670373.8127.116.camel@s1499.it.kth.se> Subject: Re: Small patch to enable build of gdb-7.6 for GNU/Hurd From: Svante Signell To: Joel Brobecker Cc: Sergio Durigan Junior , Pedro Alves , gdb-patches@sourceware.org Date: Mon, 27 May 2013 15:59:00 -0000 In-Reply-To: <20130527143053.GC5751@adacore.com> References: <20130524042734.GG4017@adacore.com> <519F2A7A.4050002@redhat.com> <1369386446.8127.51.camel@s1499.it.kth.se> <1369654913.8127.84.camel@s1499.it.kth.se> <20130527121028.GB5751@adacore.com> <1369657278.8127.90.camel@s1499.it.kth.se> <1369662500.8127.97.camel@s1499.it.kth.se> <1369663027.8127.99.camel@s1499.it.kth.se> <20130527143053.GC5751@adacore.com> Content-Type: multipart/mixed; boundary="=-bnDstnm8axEIMB96aqSW" Mime-Version: 1.0 X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00955.txt.bz2 --=-bnDstnm8axEIMB96aqSW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 490 On Mon, 2013-05-27 at 18:30 +0400, Joel Brobecker wrote: > > Additionally, I think the char buf; statement should read char *buf; in > > the patch. > > Clearly lots of errors in the patch I sent. Can you apply the changes > you suggested, recompile to make sure it at least builds, and post > again here. Because there is no testing involved, I'd like more people > to have a chance to review it before it gets checked in. > > Thank you, Ok, updated patch and ChangeLog entry attached. --=-bnDstnm8axEIMB96aqSW Content-Disposition: attachment; filename="ChangeLog.solve_PATH_MAX_issue" Content-Type: text/plain; name="ChangeLog.solve_PATH_MAX_issue"; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 206 2013-05-27 Svante Signell * nto-tdep.c (nto_init_solib_absolute_prefix): Solve build problems for systems not defining PATH_MAX by using xstrprintf followed by a cleanup. --=-bnDstnm8axEIMB96aqSW Content-Disposition: attachment; filename="solve_PATH_MAX_issue.patch" Content-Type: text/x-patch; name="solve_PATH_MAX_issue.patch"; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 922 --- a/gdb/nto-tdep.c +++ b/gdb/nto-tdep.c @@ -147,9 +147,10 @@ nto_find_and_open_solib (char *solib, unsigned o_flags, char **temp_pathname) void nto_init_solib_absolute_prefix (void) { - char buf[PATH_MAX * 2], arch_path[PATH_MAX]; + char *buf; char *nto_root, *endian; const char *arch; + struct cleanup *old_chain; nto_root = nto_target (); if (strcmp (gdbarch_bfd_arch_info (target_gdbarch ())->arch_name, "i386") == 0) @@ -172,10 +173,11 @@ nto_init_solib_absolute_prefix (void) == BFD_ENDIAN_BIG ? "be" : "le"; } - xsnprintf (arch_path, sizeof (arch_path), "%s/%s%s", nto_root, arch, endian); - - xsnprintf (buf, sizeof (buf), "set solib-absolute-prefix %s", arch_path); + buf = xstrprintf ("set solib-absolute-prefix \"%s/%s%s\"", + nto_root, arch, endian); + old_chain = make_cleanup (xfree, buf); execute_command (buf, 0); + do_cleanups (old_chain); } char ** --=-bnDstnm8axEIMB96aqSW--