From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101946-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19551 invoked by alias); 27 May 2013 13:57:15 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 19541 invoked by uid 89); 27 May 2013 13:57:15 -0000
X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1
Received: from mail-bk0-f51.google.com (HELO mail-bk0-f51.google.com) (209.85.214.51)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 27 May 2013 13:57:11 +0000
Received: by mail-bk0-f51.google.com with SMTP id ji1so1566071bkc.24        for <gdb-patches@sourceware.org>; Mon, 27 May 2013 06:57:09 -0700 (PDT)
X-Received: by 10.204.108.4 with SMTP id d4mr2966262bkp.176.1369663029425;        Mon, 27 May 2013 06:57:09 -0700 (PDT)
Received: from [130.237.20.66] (s1499.it.kth.se. [130.237.20.66])        by mx.google.com with ESMTPSA id fh8sm8454235bkc.10.2013.05.27.06.57.08        for <multiple recipients>        (version=SSLv3 cipher=RC4-SHA bits=128/128);        Mon, 27 May 2013 06:57:08 -0700 (PDT)
Message-ID: <1369663027.8127.99.camel@s1499.it.kth.se>
Subject: Re: Small patch to enable build of gdb-7.6 for GNU/Hurd
From: Svante Signell <svante.signell@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>, Pedro Alves <palves@redhat.com>,  gdb-patches@sourceware.org
Date: Mon, 27 May 2013 13:57:00 -0000
In-Reply-To: <1369662500.8127.97.camel@s1499.it.kth.se>
References: <1369326967.8127.33.camel@s1499.it.kth.se>	 <m3mwrlm6al.fsf@redhat.com> <20130524042734.GG4017@adacore.com>	 <519F2A7A.4050002@redhat.com> <1369386446.8127.51.camel@s1499.it.kth.se>	 <m3hahslp0a.fsf@redhat.com> <1369654913.8127.84.camel@s1499.it.kth.se>	 <20130527121028.GB5751@adacore.com>	 <1369657278.8127.90.camel@s1499.it.kth.se>	 <1369662500.8127.97.camel@s1499.it.kth.se>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-05/txt/msg00952.txt.bz2

On Mon, 2013-05-27 at 15:48 +0200, Svante Signell wrote:
> On Mon, 2013-05-27 at 14:21 +0200, Svante Signell wrote:
> > On Mon, 2013-05-27 at 16:10 +0400, Joel Brobecker wrote:
> > > > 2013-05-27  Svante Signell  <srs@hurd-2013.my.own.domain>
> > > > 
> > > > 	* nto-tdep.c (nto_init_solib_absolute_prefix): Solve build
> > > > 	problems for systems not defining PATH_MAX by using xstrprintf and
> > > > 	a cleanup.
> > > 
> > > Is the domain name above really valid?
> > 
> > No, it's a local one. I forgot to change that one.
> 
> Attaching an ChangeLog entry with a correct domain
> 
> > > While looking at this code, I don't think you'll need 2 xstrprintf
> > > either. Can you try the attached patch?
> > 
> > Yes, of course this code is much neater. I will report build status
> > soon.
> 
> I had to change the second make_cleanup call to do_cleanups instead, see
> the updated patch. OK now?

Additionally, I think the char buf; statement should read char *buf; in
the patch.