From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14977 invoked by alias); 27 May 2013 13:48:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14967 invoked by uid 89); 27 May 2013 13:48:24 -0000 X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS,TW_XS autolearn=ham version=3.3.1 Received: from mail-bk0-f48.google.com (HELO mail-bk0-f48.google.com) (209.85.214.48) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 27 May 2013 13:48:24 +0000 Received: by mail-bk0-f48.google.com with SMTP id jf20so2206993bkc.21 for ; Mon, 27 May 2013 06:48:21 -0700 (PDT) X-Received: by 10.205.120.208 with SMTP id fz16mr12059768bkc.1.1369662501766; Mon, 27 May 2013 06:48:21 -0700 (PDT) Received: from [130.237.20.66] (s1499.it.kth.se. [130.237.20.66]) by mx.google.com with ESMTPSA id fz10sm8436559bkc.9.2013.05.27.06.48.20 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 27 May 2013 06:48:21 -0700 (PDT) Message-ID: <1369662500.8127.97.camel@s1499.it.kth.se> Subject: Re: Small patch to enable build of gdb-7.6 for GNU/Hurd From: Svante Signell To: Joel Brobecker Cc: Sergio Durigan Junior , Pedro Alves , gdb-patches@sourceware.org Date: Mon, 27 May 2013 13:48:00 -0000 In-Reply-To: <1369657278.8127.90.camel@s1499.it.kth.se> References: <1369326967.8127.33.camel@s1499.it.kth.se> <20130524042734.GG4017@adacore.com> <519F2A7A.4050002@redhat.com> <1369386446.8127.51.camel@s1499.it.kth.se> <1369654913.8127.84.camel@s1499.it.kth.se> <20130527121028.GB5751@adacore.com> <1369657278.8127.90.camel@s1499.it.kth.se> Content-Type: multipart/mixed; boundary="=-jya1ZizHEssJWYDZJBA5" Mime-Version: 1.0 X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00951.txt.bz2 --=-jya1ZizHEssJWYDZJBA5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 800 On Mon, 2013-05-27 at 14:21 +0200, Svante Signell wrote: > On Mon, 2013-05-27 at 16:10 +0400, Joel Brobecker wrote: > > > 2013-05-27 Svante Signell > > > > > > * nto-tdep.c (nto_init_solib_absolute_prefix): Solve build > > > problems for systems not defining PATH_MAX by using xstrprintf and > > > a cleanup. > > > > Is the domain name above really valid? > > No, it's a local one. I forgot to change that one. Attaching an ChangeLog entry with a correct domain > > While looking at this code, I don't think you'll need 2 xstrprintf > > either. Can you try the attached patch? > > Yes, of course this code is much neater. I will report build status > soon. I had to change the second make_cleanup call to do_cleanups instead, see the updated patch. OK now? --=-jya1ZizHEssJWYDZJBA5 Content-Disposition: attachment; filename="ChangeLog.solve_PATH_MAX_issue" Content-Type: text/plain; name="ChangeLog.solve_PATH_MAX_issue"; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 206 2013-05-27 Svante Signell * nto-tdep.c (nto_init_solib_absolute_prefix): Solve build problems for systems not defining PATH_MAX by using xstrprintf followed by a cleanup. --=-jya1ZizHEssJWYDZJBA5 Content-Disposition: attachment; filename="nto-tdep.diff" Content-Type: text/x-patch; name="nto-tdep.diff"; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 996 diff --git a/gdb/nto-tdep.c b/gdb/nto-tdep.c index 748869f..cf4fd60 100644 --- a/gdb/nto-tdep.c +++ b/gdb/nto-tdep.c @@ -147,9 +147,10 @@ nto_find_and_open_solib (char *solib, unsigned o_flags, char **temp_pathname) void nto_init_solib_absolute_prefix (void) { - char buf[PATH_MAX * 2], arch_path[PATH_MAX]; + char buf; char *nto_root, *endian; const char *arch; + struct cleanup *old_chain; nto_root = nto_target (); if (strcmp (gdbarch_bfd_arch_info (target_gdbarch ())->arch_name, "i386") == 0) @@ -172,10 +173,11 @@ nto_init_solib_absolute_prefix (void) == BFD_ENDIAN_BIG ? "be" : "le"; } - xsnprintf (arch_path, sizeof (arch_path), "%s/%s%s", nto_root, arch, endian); - - xsnprintf (buf, sizeof (buf), "set solib-absolute-prefix %s", arch_path); + buf = xstrprintf ("set solib-absolute-prefix \"%s/%s%s\"", + nto_root, arch, endian); + old_chain = make_cleanup (xfree, buf); execute_command (buf, 0); + do_cleanups (old_chain); } char ** --=-jya1ZizHEssJWYDZJBA5--