From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20839 invoked by alias); 27 May 2013 12:21:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20828 invoked by uid 89); 27 May 2013 12:21:23 -0000 X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-bk0-f53.google.com (HELO mail-bk0-f53.google.com) (209.85.214.53) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 27 May 2013 12:21:22 +0000 Received: by mail-bk0-f53.google.com with SMTP id mx1so3671788bkb.12 for ; Mon, 27 May 2013 05:21:20 -0700 (PDT) X-Received: by 10.205.55.17 with SMTP id vw17mr12054413bkb.24.1369657280397; Mon, 27 May 2013 05:21:20 -0700 (PDT) Received: from [130.237.20.66] (s1499.it.kth.se. [130.237.20.66]) by mx.google.com with ESMTPSA id b12sm8287360bkz.0.2013.05.27.05.21.19 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 27 May 2013 05:21:19 -0700 (PDT) Message-ID: <1369657278.8127.90.camel@s1499.it.kth.se> Subject: Re: Small patch to enable build of gdb-7.6 for GNU/Hurd From: Svante Signell To: Joel Brobecker Cc: Sergio Durigan Junior , Pedro Alves , gdb-patches@sourceware.org Date: Mon, 27 May 2013 12:21:00 -0000 In-Reply-To: <20130527121028.GB5751@adacore.com> References: <1369326967.8127.33.camel@s1499.it.kth.se> <20130524042734.GG4017@adacore.com> <519F2A7A.4050002@redhat.com> <1369386446.8127.51.camel@s1499.it.kth.se> <1369654913.8127.84.camel@s1499.it.kth.se> <20130527121028.GB5751@adacore.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00948.txt.bz2 On Mon, 2013-05-27 at 16:10 +0400, Joel Brobecker wrote: > > 2013-05-27 Svante Signell > > > > * nto-tdep.c (nto_init_solib_absolute_prefix): Solve build > > problems for systems not defining PATH_MAX by using xstrprintf and > > a cleanup. > > Is the domain name above really valid? No, it's a local one. I forgot to change that one. > > Attached is an updated patch for the build problems on systems where > > PATH_MAX is not defined. > > In this case, I think you need to use what we call a "cleanup", > because execute_command might trigger an "error" (GDB's poor man's > exception mechanism), thus prevening the last xfree from releasing > buf. I thought of that problem and looking into the code for execute_command convinced me that that command should always return. Obviously I was wrong, you are the experts. > A formatting nit: The GNU Coding Standard, which we follow in GDB, > requires a space before opening parens. I just realized that after submitting the mail. > While looking at this code, I don't think you'll need 2 xstrprintf > either. Can you try the attached patch? Yes, of course this code is much neater. I will report build status soon.