From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18383 invoked by alias); 7 May 2013 10:01:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18374 invoked by uid 89); 7 May 2013 10:01:14 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 07 May 2013 10:01:13 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UZehr-0001yG-Lz from Hafiz_Abid@mentor.com ; Tue, 07 May 2013 03:01:11 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 7 May 2013 03:01:11 -0700 Received: from abidh-ubunto1104 (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 7 May 2013 11:01:09 +0100 Date: Tue, 07 May 2013 10:01:00 -0000 From: "Abid, Hafiz" Subject: Re: [PATCH 0/7] PR gdb/15224 should "set history save on" by default To: mbilal CC: , , In-Reply-To: <51877A32.1030503@codesourcery.com> (from mbilal@codesourcery.com on Mon May 6 10:38:58 2013) Message-ID: <1367920868.2238.2@abidh-ubunto1104> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-05/txt/msg00187.txt.bz2 It will be easier if you include the relevent ChangeLogs for each patch=20= =20 in the corresponding email. It makes it easy to review and make sure=20=20 that ChangeLog covers the change. I also noticed that you have not=20=20 included any ChangeLog entries for the testsuite. Regards, Abid On 06/05/13 10:38:58, mbilal wrote: > Hi, >=20 > Here is the proposed patch series of 'set history save on' by default > A thread has been discussed here=20=20 > http://sourceware.org/ml/gdb-patches/2013-04/msg00067.html >=20 >=20 >=20 >=20 > Index: ChangeLog > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/ChangeLog,v > retrieving revision 1.15497 > diff -u -p -r1.15497 ChangeLog > --- ChangeLog 1 May 2013 14:54:18 -0000 1.15497 > +++ ChangeLog 6 May 2013 09:33:22 -0000 > @@ -1,3 +1,16 @@ > +2013-05-06 Muhammad Bilal > + > + PR gdb/15224 > + * top.c (init_main): Modified write_history_p. > + (quit_force): Add condition input_from_terminal_p. > + (command_line_input): Unify interactivity tests to > + use input_from_terminal_p. > + > + * cli/cli-setshow.c (do_set_command): set history filaname > + with absolute patch. > + > + * NEWS: Updated. > + >=20 >=20 > Thanks, > -Bilal