From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15296 invoked by alias); 2 May 2013 12:03:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15208 invoked by uid 89); 2 May 2013 12:03:55 -0000 X-Spam-SWARE-Status: No, score=-8.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 02 May 2013 12:03:53 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 02 May 2013 05:03:50 -0700 X-ExtLoop1: 1 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga002.fm.intel.com with ESMTP; 02 May 2013 05:03:48 -0700 Received: from ulslx001.iul.intel.com (ulslx001.iul.intel.com [172.28.207.63]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id r42C3eYx019548; Thu, 2 May 2013 13:03:43 +0100 Received: from ulslx001.iul.intel.com (localhost [127.0.0.1]) by ulslx001.iul.intel.com with ESMTP id r42C3eiq021556; Thu, 2 May 2013 14:03:40 +0200 Received: (from mmetzger@localhost) by ulslx001.iul.intel.com with id r42C3eW3021552; Thu, 2 May 2013 14:03:40 +0200 From: Markus Metzger To: jan.kratochvil@redhat.com Cc: gdb-patches@sourceware.org Subject: [PATCH 12/15] record-btrace: provide xfer_partial target method Date: Thu, 02 May 2013 12:03:00 -0000 Message-Id: <1367496216-21217-13-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1367496216-21217-1-git-send-email-markus.t.metzger@intel.com> References: <1367496216-21217-1-git-send-email-markus.t.metzger@intel.com> X-SW-Source: 2013-05/txt/msg00022.txt.bz2 Provide the xfer_partial target method for the btrace record target. Only allow memory accesses to readonly memory while we're replaying. 2013-05-02 Markus Metzger * record-btrace.c (record_btrace_xfer_partial): New. (init_record_btrace_ops): Initialize xfer_partial. --- gdb/record-btrace.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 59 insertions(+), 0 deletions(-) diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index 20c61b7..cd17c77 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -791,6 +791,64 @@ record_btrace_is_replaying (void) return 0; } +/* The to_xfer_partial method of target record-btrace. */ + +static LONGEST +record_btrace_xfer_partial (struct target_ops *ops, enum target_object object, + const char *annex, gdb_byte *readbuf, + const gdb_byte *writebuf, ULONGEST offset, + LONGEST len) +{ + struct target_ops *t; + + /* Normalize the request so len is positive. */ + if (len < 0) + { + offset += len; + len = - len; + } + + /* Filter out requests that don't make sense during replay. */ + if (record_btrace_is_replaying ()) + { + switch (object) + { + case TARGET_OBJECT_MEMORY: + case TARGET_OBJECT_RAW_MEMORY: + case TARGET_OBJECT_STACK_MEMORY: + { + /* We allow reading readonly memory. */ + struct target_section *section; + + section = target_section_by_addr (ops, offset); + if (section != NULL) + { + /* Check if the section we found is readonly. */ + if ((bfd_get_section_flags (section->bfd, + section->the_bfd_section) + & SEC_READONLY) != 0) + { + /* Truncate the request to fit into this section. */ + len = min (len, section->endaddr - offset); + break; + } + } + + throw_error (NOT_AVAILABLE_ERROR, + _("This record target does not trace memory.")); + } + } + } + + /* Forward the request. */ + for (t = ops->beneath; t != NULL; t = t->beneath) + if (t->to_xfer_partial != NULL) + return t->to_xfer_partial (t, object, annex, readbuf, writebuf, + offset, len); + + return -1; +} + /* The to_fetch_registers method of target record-btrace. */ static void @@ -975,6 +1033,7 @@ init_record_btrace_ops (void) ops->to_call_history_from = record_btrace_call_history_from; ops->to_call_history_range = record_btrace_call_history_range; ops->to_record_is_replaying = record_btrace_is_replaying; + ops->to_xfer_partial = record_btrace_xfer_partial; ops->to_fetch_registers = record_btrace_fetch_registers; ops->to_store_registers = record_btrace_store_registers; ops->to_prepare_to_store = record_btrace_prepare_to_store; -- 1.7.1