From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11882 invoked by alias); 30 Apr 2013 10:53:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11872 invoked by uid 89); 30 Apr 2013 10:53:49 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Apr 2013 10:53:48 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UX8Bu-0003H6-M9 from Hafiz_Abid@mentor.com ; Tue, 30 Apr 2013 03:53:46 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 30 Apr 2013 03:53:46 -0700 Received: from abidh-ubunto1104 (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 30 Apr 2013 11:53:44 +0100 Date: Tue, 30 Apr 2013 16:29:00 -0000 From: "Abid, Hafiz" Subject: Re: [patch, sim] Add isel instruction To: Joel Brobecker CC: , References: <1366391706.7941.1@abidh-ubunto1104> <20130430104701.GA16143@adacore.com> In-Reply-To: <20130430104701.GA16143@adacore.com> (from brobecker@adacore.com on Tue Apr 30 11:47:01 2013) Message-ID: <1367319223.12146.2@abidh-ubunto1104> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-04/txt/msg00898.txt.bz2 Joel, Thansk for lettting me know. If this is urgent for you then I can=20=20 revert as it may take me some time to find a fix. Regards, Abid On 30/04/13 11:47:01, Joel Brobecker wrote: > Abid, >=20 > > This patch adds support for isel instruction in the ppc simulator. > > Tested manually by running a small assembly file through the > > simulator. Is this ok? > > > > Regards, > > Abid > > > > sim/ChangeLog: > > 2013-04-19 Nathan Froyd > > > > * ppc-instructions (isel): New instruction. >=20 > This patch causes the sim build to fail when configured with > --enable-sim-float=3Dspe. The full configure command-line used was: >=20 > % configure --disable-nls --disable-tui --without-zlib=20=20 > --prefix=3D/[...]/install --enable-sim --enable-sim-float=3Dspe=20=20 > --without-python --with-libexpat-prefix=3D/[...]/libexpat=20=20 > --target=3Dpowerpc-eabispe >=20 > The error I get is: >=20 > | ./igen -E -F 32,f,o,e500 -CSRI 1024 -N 5 \ > | [...] > | expanding ... > | -n icache.h > | -h > | -c tmp-icache.h > | gen-icache.c:66: assertion failed - entry->nr_insn =3D=3D 1 > | make: *** [tmp-igen] Error 1 >=20 > I am not familiar with this part of the code, so can you please fix > or revert? >=20 > Interestingly, no problem with --enable-sim-float=3Daltivec. >=20 > Thank you. >=20 > > > > diff --git a/sim/ppc/ppc-instructions b/sim/ppc/ppc-instructions > > index 1b8fd89..d76a765 100644 > > --- a/sim/ppc/ppc-instructions > > +++ b/sim/ppc/ppc-instructions > > @@ -3455,6 +3455,19 @@ > > void::function::invalid_zero_divide_operation:cpu *processor, > > unsigned_word cia, > > PPC_INSN_MFCR(RT_BITMASK); > > > > # > > +# I.3.3.15 Fixed-Point Select > > +# > > + > > +0.31,6.RT,11.RA,16.RB,21.BF,26.15,31./:A::isel:Integer Select > > + unsigned_word a; > > + if (RA_is_0) a =3D 0; > > + else a =3D *rA; > > + if (CR & (1 << (31 - BF))) > > + *rT =3D a; > > + else > > + *rT =3D *rB; > > + > > +# >=20 > -- > Joel >=20