Hi Hui, > + putpkt (buf); > + remote_get_noisy_reply (&target_buf, &target_buf_size); > + if (strcmp (target_buf, "OK")) > + warning (_("\ Just a small comment on style. I think it is better to be explicit in such case and write != 0. Also I was advised by Pedro recently that new packets should be using packet_ok which will eliminate the need for strcmp here anyway. > + putpkt ("qTDC"); > + getpkt (&rs->buf, &rs->buf_size, 0); > + if (strncmp (rs->buf, "DC", 2)) > + { Why not remote_get_noisy_reply here. Regards, Abid From gdb-patches-return-100409-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Apr 11 16:55:38 2013 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 16574 invoked by alias); 11 Apr 2013 16:55:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 16523 invoked by uid 89); 11 Apr 2013 16:55:37 -0000 X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_YM autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 11 Apr 2013 16:55:37 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3BGtZKn021045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits%6 verify=OK) for ; Thu, 11 Apr 2013 12:55:35 -0400 Received: from host2.jankratochvil.net (ovpn-116-44.ams2.redhat.com [10.36.116.44]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3BGtV1f016475 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits8 verify=NO); Thu, 11 Apr 2013 12:55:34 -0400 Date: Thu, 11 Apr 2013 22:59:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Tom Tromey , Pedro Alves Subject: [commit#2] configure.tgt gcore fix [Re: [commit] [patch 2/2+rfc+doc] Install gcore by default (+new man page)] Message-ID: <20130411165531.GA1381@host2.jankratochvil.net> References: <20130407185443.GB15389@host2.jankratochvil.net> <83r4ilawlx.fsf@gnu.org> <20130408172841.GA28868@host2.jankratochvil.net> <87hajgua2o.fsf@fleche.redhat.com> <516424FE.4050307@redhat.com> <20130409165525.GA29570@host2.jankratochvil.net> <51654DF0.3090101@redhat.com> <20130410194910.GA3941@host2.jankratochvil.net> <51669166.5060007@redhat.com> <20130411142957.GA22567@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130411142957.GA22567@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-04/txt/msg00335.txt.bz2 Content-length: 1390 On Thu, 11 Apr 2013 16:29:57 +0200, Jan Kratochvil wrote: > Checked in. I have found gcore is not available for: i[34567]86-*-linux*) ^I# Target: Intel 386 running GNU/Linux ^Igdb_target_obs="i386-tdep.o i386-linux-tdep.o glibc-tdep.o i387-tdep.o \ ^I^I^Isolib-svr4.o symfile-mem.o \ ^I^I^Ilinux-tdep.o linux-record.o" because " linux-tdep.o " is not found there. Checked in. Sorry, Jan http://sourceware.org/ml/gdb-cvs/2013-04/msg00110.html --- src/gdb/ChangeLog 2013/04/11 14:13:42 1.15398 +++ src/gdb/ChangeLog 2013/04/11 16:53:01 1.15399 @@ -22,6 +22,9 @@ * gcore.in: ... here. Remove gcore.sh comment. Use GDB_TRANSFORM_NAME and GCORE_TRANSFORM_NAME substitutions. + Fix parsing tabs in ${gdb_target_obs}. + * configure.tgt (gdb_have_gcore): Replace case with for and if. + 2013-04-11 Jan Kratochvil * remote.c (unpush_and_perror): Add output message final dot. --- src/gdb/configure.tgt 2013/04/11 14:13:43 1.273 +++ src/gdb/configure.tgt 2013/04/11 16:53:01 1.274 @@ -707,11 +707,9 @@ # Check whether this target supports gcore. # Such target has to call set_gdbarch_find_memory_regions. -case " ${gdb_target_obs} " in - *" linux-tdep.o "*) +gdb_have_gcoreślse +for t in x ${gdb_target_obs}; do + if test "$t" = linux-tdep.o; then gdb_have_gcore=true - ;; - *) - gdb_have_gcoreślse - ;; -esac + fi +done